From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCKm-0000J5-Mp for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:16:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeCKh-0008M9-QT for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:16:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42859) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCKh-0008M5-IN for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:16:19 -0500 Message-ID: <527ACDA9.7000003@redhat.com> Date: Wed, 06 Nov 2013 16:15:53 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-12-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-12-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tI157ADkoRwIUcjD4nlLfj9pNf0As1xTo" Subject: Re: [Qemu-devel] [PATCH 11/39] memory: cpu_physical_memory_set_dirty_range() allways dirty all flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tI157ADkoRwIUcjD4nlLfj9pNf0As1xTo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 06:04 AM, Juan Quintela wrote: s/allways dirty/always dirties/ in the subject > So remove the flag argument and do it directly. After this change, the= re is nothing else using cpu_physical_memory_set_dirty_flags() so remove = it. Any reason you didn't line wrap the commit message? >=20 > Signed-off-by: Juan Quintela > --- > exec.c | 2 +- > include/exec/memory-internal.h | 11 ++--------- > memory.c | 2 +- > 3 files changed, 4 insertions(+), 11 deletions(-) But the code itself is correct. For 9 through 11: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tI157ADkoRwIUcjD4nlLfj9pNf0As1xTo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSes2pAAoJEKeha0olJ0Nqh7IIAI1v5VsqkHe9R0AKaTsupydd yChPajCLQdfs50j6IGFWdsusGvbWtdNR55hKivvVEFr+jW0YXU9QDtLmjU8U0nyA WwyJlrjaP0duGWcC/QXG8FAeyh+Ufg+3QuMT5ErfJ773tLttGT+HOM+YQrXQfY5A aZP9OrLayoqfb2PCDhD4SYKUMcqJTyuqNHkdpqWfdzh7auAoTe3jqJRL2Dvatg3N ZJMnKAsDlmu8+DbpzQL2RlxwsBFRw31g1ykX8n3KLw6l6J2KpxBj7hTbvZ2PLaeF Wh1k08V2RH2AoXAAH+ckRKr299V4sfNJpvDLVc1cEuyjj5BfLZ+zjL6r+73X+Is= =cWwM -----END PGP SIGNATURE----- --tI157ADkoRwIUcjD4nlLfj9pNf0As1xTo--