From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCSf-0007Mh-6w for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:24:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeCSW-00029O-RR for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:24:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18238) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeCSW-000293-GX for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:24:24 -0500 Message-ID: <527ACFA5.9050402@redhat.com> Date: Wed, 06 Nov 2013 16:24:21 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-14-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-14-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f5LhEIar4sd5VNx2X593rioAeO4qrRPXX" Subject: Re: [Qemu-devel] [PATCH 13/39] memory: use DIRTY_MEMORY_* instead of *_DIRTY_FLAG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f5LhEIar4sd5VNx2X593rioAeO4qrRPXX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 06:04 AM, Juan Quintela wrote: > Instead of the bitmap, we use the bitmap number. Once this is done, > we change all names from dirty_flag to memory regions naming of > client. >=20 > Signed-off-by: Juan Quintela > --- > cputlb.c | 4 ++-- > exec.c | 18 +++++++++--------- > include/exec/memory-internal.h | 38 +++++++++++++++++-----------------= ---- > include/exec/memory.h | 3 --- > memory.c | 10 ++++------ > 5 files changed, 32 insertions(+), 41 deletions(-) >=20 > - > static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,= > - int dirty_flag) > + unsigned client)= Aha - you fixed the other whitespace nit I pointed out on 6/39. Since both nits were transient, it's not worth respinning that patch just for whitespace. And since my subsequent nits in commit headers could be touched up by a maintainer when adding my Reviewed-by, you may have escaped a respin if the rest of the series is clean :) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f5LhEIar4sd5VNx2X593rioAeO4qrRPXX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSes+lAAoJEKeha0olJ0Nqm78IAKQHUl8/0p6onJd4ms6NunvC O7JTn7Vwuc/YLZHaNUy89zfAQaHg9hXMOyg3M92TYqkFgWh2AR1My/XGjUVXh4r0 hjPADkstFCcl/zaHDQg7Dw9ydpRGYUDj8etvd9qH/1Qh5J20LlIrWS8irize8fps fD5uDPa3FR1x1TvWcbfGaNKDijidw4FKAX8o1JdxPlqUZ6yE8AtmiV+tLASY9E0E 0FowMXQi7WhsEh2Zw2F7ml/5M9yiGJUlTFLDV/RakyKdfwGU46eM2IlqJ1pdjVcV W2gTvjJGAteAJg6SEuX6hvv8TcWV1Y5v1c3NWM+gPd7WQJ3677NVHkc8HBVpHKk= =BUWc -----END PGP SIGNATURE----- --f5LhEIar4sd5VNx2X593rioAeO4qrRPXX--