From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeChe-0003Yj-Gw for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:40:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeChY-00076q-8q for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:40:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeChX-00076m-Vt for qemu-devel@nongnu.org; Wed, 06 Nov 2013 18:39:56 -0500 Message-ID: <527AD348.9010901@redhat.com> Date: Wed, 06 Nov 2013 16:39:52 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-20-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-20-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KgkIkEPIGgOLLdb53AArXHTmkm3rfvN51" Subject: Re: [Qemu-devel] [PATCH 19/39] memory: split dirty bitmap into three List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org Cc: chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KgkIkEPIGgOLLdb53AArXHTmkm3rfvN51 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/06/2013 06:04 AM, Juan Quintela wrote: > After all the previous patches, spliting the bitmap gets direct. >=20 > ToDo: Why can't i include "exec/memory.h" into cpu-all.h? This is the > reason that I have duplicated DIRTY_MEMORY_NUM. >=20 > ToDo2: current bitmaps have one int as index, this limit us to 8TB RAM > guest, Should we move to longs? Do we still want "ToDo" in the commit message? >=20 > Signed-off-by: Juan Quintela > --- > exec.c | 9 ++++++--- > include/exec/cpu-all.h | 4 +++- > include/exec/memory-internal.h | 11 ++++------- > 3 files changed, 13 insertions(+), 11 deletions(-) But the code looks correct. For 14-19, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KgkIkEPIGgOLLdb53AArXHTmkm3rfvN51 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSetNIAAoJEKeha0olJ0NqQGYIAIsUVXaV7Zr0L8N4dUVFRmro aGanUyfh1rgwqlrc/ZVUW+cA6cu14Cko2bBIUFduqQhjJek3pb5u4g3A0/M1ZWUc xdnFYWm5I/nFzv9FbxH9pmmgyRj4RI08q7NmP+4G9R4Y+bq47vxxKMJrKRqXsymb tvDeWRaewMlBsUV8BMKEsTwAQNL08gCMm2WPQ5XJ4ilvO+drk40dGk9IAVsSeNHs 28EGTCMNUevy3eC4YPCjOE4/5VF1tgBqCXi5qQ3BDzwlRHiL4lR9TzQDL4OoYxbT lCuysRF9U058KCwleJDeeX787ueVc5a1TNmwd6VlF5//+fhzRVTFCUKrdOMUw7w= =EAaH -----END PGP SIGNATURE----- --KgkIkEPIGgOLLdb53AArXHTmkm3rfvN51--