From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeFQC-000068-TU for qemu-devel@nongnu.org; Wed, 06 Nov 2013 21:34:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeFQ5-0005LD-Ac for qemu-devel@nongnu.org; Wed, 06 Nov 2013 21:34:12 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:39578) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeFQ4-0005L3-Lm for qemu-devel@nongnu.org; Wed, 06 Nov 2013 21:34:05 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 7 Nov 2013 12:33:59 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id BB1DC2CE8052 for ; Thu, 7 Nov 2013 13:33:56 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rA72Xirg6881554 for ; Thu, 7 Nov 2013 13:33:44 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rA72Xun3013844 for ; Thu, 7 Nov 2013 13:33:56 +1100 Message-ID: <527AFC15.2000702@linux.vnet.ibm.com> Date: Thu, 07 Nov 2013 10:33:57 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1383611860-9053-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1383611860-9053-8-git-send-email-xiawenc@linux.vnet.ibm.com> <5278F56E.70104@redhat.com> <5279B568.5070906@linux.vnet.ibm.com> <527A4535.50402@redhat.com> In-Reply-To: <527A4535.50402@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH RFC 07/10] qapi script: support direct inheritance for struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, Amos Kong , armbru@redhat.com, lcapitulino@redhat.com 于 2013/11/6 21:33, Eric Blake 写道: > On 11/05/2013 08:20 PM, Wenchao Xia wrote: >>>> + 'server': { >>>> + '_base': 'NetworkConnectionInfo', >>> >>> Interesting idea for shorthand. However, I would suggest that you pick >>> a different character than '_', since '_' is valid in names. That is, >>> we already have special handling of leading '*' to mark a field as >>> optional, so I suggest something like '^' to mark a base class. By >>> using a non-name character, it becomes more obvious that the leading >>> character has a special meaning to the qapi generator. >>> >>> I'm also not convinced yet that we want this shorthand; in particular, >>> I'm worried whether it will make the introspection patches harder to >>> write. >>> >> I am not sure about this approach either, so put RFC tag on it. The >> purpose is allow not to define structures that would be only used once. >> >> What instrospection patch do you mean? Python instrospection >> mechnism? You mean there is a python utility which recognize >> only keyword "base" now? > > No, I'm talking about Amos' patches to expose the qapi to the user via a > QMP command. Last version proposed was here: > https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg02494.html > although with the addition of discriminated union types in the meantime, > my understanding is Amos is planning on posting another version soon for > the 1.8 timeframe. > I'll drop this patch now.