Re: [Qemu-devel] [PATCH 01/39] Move prototypes to memory.h

[Orit Wasserman <owasserm@redhat.com>]

On 11/06/2013 03:04 PM, Juan Quintela wrote:
> As the comment says, it should only be used on "core" memory files.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>   include/exec/cpu-common.h | 4 ----
>   include/exec/memory.h     | 4 +++-
>   2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> index e4996e1..8110ef0 100644
> --- a/include/exec/cpu-common.h
> +++ b/include/exec/cpu-common.h
> @@ -51,10 +51,6 @@ typedef void CPUWriteMemoryFunc(void *opaque, hwaddr addr, uint32_t value);
>   typedef uint32_t CPUReadMemoryFunc(void *opaque, hwaddr addr);
>
>   void qemu_ram_remap(ram_addr_t addr, ram_addr_t length);
> -/* This should not be used by devices.  */
> -MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr);
> -void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev);
> -
>   void cpu_physical_memory_rw(hwaddr addr, uint8_t *buf,
>                               int len, int is_write);
>   static inline void cpu_physical_memory_read(hwaddr addr,
> diff --git a/include/exec/memory.h b/include/exec/memory.h
> index 480dfbf..c7e151f 100644
> --- a/include/exec/memory.h
> +++ b/include/exec/memory.h
> @@ -1055,7 +1055,9 @@ void *address_space_map(AddressSpace *as, hwaddr addr,
>   void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len,
>                            int is_write, hwaddr access_len);
>
> -
> +/* This should not be used by devices.  */
> +MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr);
> +void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev);
>   #endif
>
>   #endif
>

Reviewed-by: Orit Wasserman <owasserm@redhat.com>