From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeM0W-0007PV-3O for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:36:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeM0Q-00036X-16 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:36:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeM0P-00035c-PK for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:36:01 -0500 Message-ID: <527B5F1E.6030606@redhat.com> Date: Thu, 07 Nov 2013 11:36:30 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-2-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-2-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/39] Move prototypes to memory.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org On 11/06/2013 03:04 PM, Juan Quintela wrote: > As the comment says, it should only be used on "core" memory files. > > Signed-off-by: Juan Quintela > --- > include/exec/cpu-common.h | 4 ---- > include/exec/memory.h | 4 +++- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h > index e4996e1..8110ef0 100644 > --- a/include/exec/cpu-common.h > +++ b/include/exec/cpu-common.h > @@ -51,10 +51,6 @@ typedef void CPUWriteMemoryFunc(void *opaque, hwaddr addr, uint32_t value); > typedef uint32_t CPUReadMemoryFunc(void *opaque, hwaddr addr); > > void qemu_ram_remap(ram_addr_t addr, ram_addr_t length); > -/* This should not be used by devices. */ > -MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); > -void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev); > - > void cpu_physical_memory_rw(hwaddr addr, uint8_t *buf, > int len, int is_write); > static inline void cpu_physical_memory_read(hwaddr addr, > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 480dfbf..c7e151f 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -1055,7 +1055,9 @@ void *address_space_map(AddressSpace *as, hwaddr addr, > void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, > int is_write, hwaddr access_len); > > - > +/* This should not be used by devices. */ > +MemoryRegion *qemu_ram_addr_from_host(void *ptr, ram_addr_t *ram_addr); > +void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev); > #endif > > #endif > Reviewed-by: Orit Wasserman