From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60313)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1VeM69-0000TQ-Ff
	for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:42:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1VeM63-0004rG-FF
	for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:41:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:18466)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1VeM63-0004qz-8B
	for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:41:51 -0500
Message-ID: <527B607B.5060202@redhat.com>
Date: Thu, 07 Nov 2013 11:42:19 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1383743088-8139-1-git-send-email-quintela@redhat.com>
	<1383743088-8139-3-git-send-email-quintela@redhat.com>
In-Reply-To: <1383743088-8139-3-git-send-email-quintela@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/39] memory:
 cpu_physical_memory_set_dirty_flags() result is never used
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org

On 11/06/2013 03:04 PM, Juan Quintela wrote:
> So return void.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>   include/exec/memory-internal.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
> index d0e0633..c71a5e6 100644
> --- a/include/exec/memory-internal.h
> +++ b/include/exec/memory-internal.h
> @@ -70,10 +70,10 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t start,
>       return ret;
>   }
>
> -static inline int cpu_physical_memory_set_dirty_flags(ram_addr_t addr,
> +static inline void cpu_physical_memory_set_dirty_flags(ram_addr_t addr,
>                                                         int dirty_flags)
>   {
> -    return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] |= dirty_flags;
> +    ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] |= dirty_flags;
>   }
>
>   static inline void cpu_physical_memory_set_dirty(ram_addr_t addr)
>

Reviewed-by: Orit Wasserman <owasserm@redhat.com>