From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeMEl-0003Bx-He for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:50:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeMEf-0007rr-Jg for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:50:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeMEf-0007rj-Am for qemu-devel@nongnu.org; Thu, 07 Nov 2013 04:50:45 -0500 Message-ID: <527B6292.4060404@redhat.com> Date: Thu, 07 Nov 2013 11:51:14 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-4-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-4-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org On 11/06/2013 03:04 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/memory.c b/memory.c > index 28f6449..9722f23 100644 > --- a/memory.c > +++ b/memory.c > @@ -1182,7 +1182,7 @@ void memory_region_set_dirty(MemoryRegion *mr, hwaddr addr, > hwaddr size) > { > assert(mr->terminates); > - return cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1); > + cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1); > } > > bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr, > Reviewed-by: Orit Wasserman