From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeMO8-0007Dt-HW for qemu-devel@nongnu.org; Thu, 07 Nov 2013 05:00:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeMO2-0002e3-Iq for qemu-devel@nongnu.org; Thu, 07 Nov 2013 05:00:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeMO2-0002dq-3o for qemu-devel@nongnu.org; Thu, 07 Nov 2013 05:00:26 -0500 Message-ID: <527B64C7.3060804@redhat.com> Date: Thu, 07 Nov 2013 12:00:39 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-5-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-5-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org On 11/06/2013 03:04 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/exec.c b/exec.c > index 79610ce..7cf5634 100644 > --- a/exec.c > +++ b/exec.c > @@ -1397,7 +1397,7 @@ static void notdirty_mem_write(void *opaque, hwaddr ram_addr, > cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags); > /* we remove the notdirty callback only if the code has been > flushed */ > - if (dirty_flags == 0xff) { > + if (cpu_physical_memory_is_dirty(ram_addr)) { > CPUArchState *env = current_cpu->env_ptr; > tlb_set_dirty(env, env->mem_io_vaddr); > } > Reviewed-by: Orit Wasserman