qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] qemu-iotests: use blkdebug to make test deterministic
Date: Thu, 07 Nov 2013 12:33:04 +0100	[thread overview]
Message-ID: <527B7A70.50607@redhat.com> (raw)
In-Reply-To: <527B789A.8000002@redhat.com>

Il 07/11/2013 12:25, Fam Zheng ha scritto:
> Mirror doesn't complete automatically, so we don't need the sequence:
> 
> 1) Pause IO on device.
> 2) Start job.
> 3) Send block job cancel/complete command to wire.
> 4) Resume IO.
> 
> Block stream/commit/backup need because without step 1) the job could
> complete after 2) but before 3), so the block-job-complete may get an
> error return (no job no device).
> 
> Is it?

Yes.

> So I'll review commit and backup cases then.

Yes.

Paolo

      reply	other threads:[~2013-11-07 11:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-30  9:42 [Qemu-devel] [PATCH v2] qemu-iotests: prefill some data to test image Fam Zheng
2013-10-30 11:15 ` Kevin Wolf
2013-10-30 11:31   ` Fam Zheng
2013-10-30 11:51     ` Kevin Wolf
2013-10-31  2:18 ` [Qemu-devel] [PATCH v3] qemu-iotests: use blkdebug to make test deterministic Fam Zheng
2013-11-06 12:03   ` Stefan Hajnoczi
2013-11-07  7:58     ` Fam Zheng
2013-11-06 12:10   ` Paolo Bonzini
2013-11-07 10:51     ` Fam Zheng
2013-11-07 11:25     ` Fam Zheng
2013-11-07 11:33       ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=527B7A70.50607@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).