From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeNpp-00016a-F8 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 06:33:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeNpj-00073k-3r for qemu-devel@nongnu.org; Thu, 07 Nov 2013 06:33:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeNpi-00073c-TD for qemu-devel@nongnu.org; Thu, 07 Nov 2013 06:33:07 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA7BX62h004455 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Nov 2013 06:33:06 -0500 Message-ID: <527B7A70.50607@redhat.com> Date: Thu, 07 Nov 2013 12:33:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1383126148-1664-1-git-send-email-famz@redhat.com> <1383185888-8131-1-git-send-email-famz@redhat.com> <527A31CC.7070806@redhat.com> <527B789A.8000002@redhat.com> In-Reply-To: <527B789A.8000002@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] qemu-iotests: use blkdebug to make test deterministic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com Il 07/11/2013 12:25, Fam Zheng ha scritto: > Mirror doesn't complete automatically, so we don't need the sequence: > > 1) Pause IO on device. > 2) Start job. > 3) Send block job cancel/complete command to wire. > 4) Resume IO. > > Block stream/commit/backup need because without step 1) the job could > complete after 2) but before 3), so the block-job-complete may get an > error return (no job no device). > > Is it? Yes. > So I'll review commit and backup cases then. Yes. Paolo