From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeNu7-0006hJ-Ur for qemu-devel@nongnu.org; Thu, 07 Nov 2013 06:37:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeNu1-000078-W9 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 06:37:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeNu1-00006e-O4 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 06:37:33 -0500 Message-ID: <527B7B92.5070909@redhat.com> Date: Thu, 07 Nov 2013 13:37:54 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1383743088-8139-1-git-send-email-quintela@redhat.com> <1383743088-8139-6-git-send-email-quintela@redhat.com> In-Reply-To: <1383743088-8139-6-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: chegu_vinod@hp.com, qemu-devel@nongnu.org On 11/06/2013 03:04 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > cputlb.c | 2 +- > include/exec/memory-internal.h | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/cputlb.c b/cputlb.c > index fff0afb..72452e5 100644 > --- a/cputlb.c > +++ b/cputlb.c > @@ -137,7 +137,7 @@ void tlb_protect_code(ram_addr_t ram_addr) > void tlb_unprotect_code_phys(CPUArchState *env, ram_addr_t ram_addr, > target_ulong vaddr) > { > - cpu_physical_memory_set_dirty_flags(ram_addr, CODE_DIRTY_FLAG); > + cpu_physical_memory_set_dirty_flag(ram_addr, CODE_DIRTY_FLAG); > } > > static bool tlb_is_dirty_ram(CPUTLBEntry *tlbe) > diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h > index c71a5e6..4ebab80 100644 > --- a/include/exec/memory-internal.h > +++ b/include/exec/memory-internal.h > @@ -76,6 +76,12 @@ static inline void cpu_physical_memory_set_dirty_flags(ram_addr_t addr, > ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] |= dirty_flags; > } > > +static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr, > + int dirty_flag) > +{ > + ram_list.phys_dirty[addr >> TARGET_PAGE_BITS] |= dirty_flag; > +} > + > static inline void cpu_physical_memory_set_dirty(ram_addr_t addr) > { > cpu_physical_memory_set_dirty_flags(addr, 0xff); > Reviewed-by: Orit Wasserman