From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeWHV-0005Ev-4s for qemu-devel@nongnu.org; Thu, 07 Nov 2013 15:34:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VeWHL-0000cy-Ko for qemu-devel@nongnu.org; Thu, 07 Nov 2013 15:34:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VeWHL-0000cr-B5 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 15:34:11 -0500 Message-ID: <527BF93E.8000108@redhat.com> Date: Thu, 07 Nov 2013 13:34:06 -0700 From: Eric Blake MIME-Version: 1.0 References: <1383836503-25447-1-git-send-email-benoit@irqsave.net> In-Reply-To: <1383836503-25447-1-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i0wOKA31Nw1Wb94DmWCHuSIBb5T2aH5dc" Subject: Re: [Qemu-devel] [PATCH 0/2] Giving names to graph's BlockDriverState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i0wOKA31Nw1Wb94DmWCHuSIBb5T2aH5dc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/07/2013 08:01 AM, Beno=C3=AEt Canet wrote: > The following series introduce a new file.node-name property in order t= o be > able to give a name to each BlockDriverState of the graph. >=20 > It also define "undefined" as a special value for node-name; a value th= at will be > used to indicate to the management that it can not manipulate a node be= cause it > was not named. Is it necessary to use the actual string "undefined" to mean unnamed, or can we be careful and use NULL for unnamed, and all other pointers as the user-provided name? Either way, we have to special-case code to check for the sentinel, but a NULL check is faster than a strcmp(), plus it feels slightly nicer to not consume a value out of the user's namespac= e. >=20 > After this patchset is merged I would like to take care of presenting t= he graph > to the management. (HMP &&/|| QMP) >=20 > Eric: Do you have some ideas on this topic ? Overall, I'm looking forward to getting this into qemu 1.8; I'm still waiting to see what else you propose for QMP interfaces. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --i0wOKA31Nw1Wb94DmWCHuSIBb5T2aH5dc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSe/k+AAoJEKeha0olJ0NqB0kH/2ITaNuQQ63kJ17DPRYKqM+J dIp+CLmIGYDNWcMgnrTsT1zRegakkmJmyDD8W6MzJxRXcHkRp0c2dYjRq9XgC0zk NWEDjFWVBFLqwbLpebCgVTIwbGA6reGuy8sJBN6bna3q7uv465nWo20Ydy0IgwHB DrYMjfqKnFOlwhMEV3v9AvAfQmuf6zvF52m9zcMtvJuF4TYTfDPfe+TVOW2KBwS0 hvlUAjb6bbt+df2aHh1N8PwM1BR+Bns6XX5ZIbYMHuNvapJzV0A5wyBYKU3nR/8S /6PsfpNuv4ndHKJOFguaJPqrbu/0701A8x9ORjJsbhPtYivmIrSfVV5o3oNsiL8= =PH6h -----END PGP SIGNATURE----- --i0wOKA31Nw1Wb94DmWCHuSIBb5T2aH5dc--