From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56995)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VeX96-00010F-Fj
	for qemu-devel@nongnu.org; Thu, 07 Nov 2013 16:29:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VeX8y-00023K-Ml
	for qemu-devel@nongnu.org; Thu, 07 Nov 2013 16:29:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:7293)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VeX8y-00021x-DC
	for qemu-devel@nongnu.org; Thu, 07 Nov 2013 16:29:36 -0500
Message-ID: <527C06D1.8060504@redhat.com>
Date: Thu, 07 Nov 2013 22:32:01 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1383511723-11228-1-git-send-email-marcel.a@redhat.com>
	<CAFe8ug9hauGmXE6GFKa6sRzQ3Thm=RmAh4EQsoYMeOS9j_RyjA@mail.gmail.com>
	<527C023F.2060506@redhat.com> <527C0474.7010107@redhat.com>
In-Reply-To: <527C0474.7010107@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [edk2] [PATCH] exec: fix regression by making
 system-memory region UINT64_MAX size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Marcel Apfelbaum <marcel.a@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, edk2-devel@lists.sourceforge.net, qemu-devel <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, afaerber <afaerber@suse.de>, rth@twiddle.net

On 11/07/13 22:21, Paolo Bonzini wrote:
> Il 07/11/2013 22:12, Laszlo Ersek ha scritto:
>> 0000000000000000-7ffffffffffffffe (prio 0, RW): system
>>   [...]
>>   0000000060000000-00000000ffffffff (prio 0, RW): alias pci-hole @pci 0000000060000000-00000000ffffffff
>>   [...]
>>   00000000ffe00000-00000000ffffffff (prio 0, R-): system.flash
>> [...]
> 
> Priorities are not "transitive" across aliases; once you use an alias to
> map a region, the alias's priority counts, not the target region's
> priority.  So the INT_MIN priority for pci-master-abort counts *within
> the alias*, but the choice between pci-hole and system.flash is only
> affected by the priorities of pci-hole and system.flash.

Right. It's also documented in docs/memory.txt -- Peter's recent
addition I think?

> You could give a smaller priority (-1 or INT_MIN) to pci-hole and just
> let it occupy the whole address space, from 0 to UINT64_MAX.  Or perhaps
> the pci-hole alias is too large and it should end before the system
> flash area.  Both solutions should work.

I did reorder pci-hole and system.flash, but rather than lowering
pci-hole, I raised system.flash. I have no preference.

Thanks
Laszlo