From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vec7w-0004ex-6M for qemu-devel@nongnu.org; Thu, 07 Nov 2013 21:49:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vec7n-0001t6-3H for qemu-devel@nongnu.org; Thu, 07 Nov 2013 21:48:52 -0500 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:33041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vec7m-0001rl-A1 for qemu-devel@nongnu.org; Thu, 07 Nov 2013 21:48:43 -0500 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 8 Nov 2013 12:48:14 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 78DF82BB0057 for ; Fri, 8 Nov 2013 13:48:11 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rA82loxs9961920 for ; Fri, 8 Nov 2013 13:47:59 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rA82m2GS014993 for ; Fri, 8 Nov 2013 13:48:02 +1100 Message-ID: <527C50E4.1050402@linux.vnet.ibm.com> Date: Fri, 08 Nov 2013 10:48:04 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1383850068-3903-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1383850068-3903-1-git-send-email-mreitz@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] qapi-schema: Update description for NewImageMode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi ÓÚ 2013/11/8 2:47, Max Reitz дµÀ: > If the NewImageMode is "absolute-paths" but no backing file is available > (e.g., when mirroring a device with an unbacked image), the target image > will not be backed either. This patch updates the documentation in > qapi-schema.json accordingly. > > Signed-off-by: Max Reitz > --- > Follow-up to: > - block/drive-mirror: Check for NULL backing_hd > --- > qapi-schema.json | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..dde8e45 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1736,7 +1736,8 @@ > # @existing: QEMU should look for an existing image file. > # > # @absolute-paths: QEMU should create a new image with absolute paths > -# for the backing file. > +# for the backing file. If there is no backing file available, the new > +# image will not be backed either. > # > # Since: 1.1 > ## > It seems 2nd line should start with space, how about: # @absolute-paths: QEMU should create a new image with absolute paths, # the new image would usually have a backing file. If # no backing file available, the new image will not be # backed either.