From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VecUt-0000Lf-6w for qemu-devel@nongnu.org; Thu, 07 Nov 2013 22:12:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VecUk-0000Lb-9B for qemu-devel@nongnu.org; Thu, 07 Nov 2013 22:12:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VecUk-0000LF-0y for qemu-devel@nongnu.org; Thu, 07 Nov 2013 22:12:26 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rA83COLP027475 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Nov 2013 22:12:24 -0500 Message-ID: <527C5694.7030000@redhat.com> Date: Fri, 08 Nov 2013 11:12:20 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1381295983-18945-1-git-send-email-famz@redhat.com> In-Reply-To: <1381295983-18945-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/6] block: allow commit active as top List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, jcody@redhat.com, stefanha@redhat.com On 10/09/2013 01:19 PM, Fam Zheng wrote: > Previously live commit of active block device is not supported, this series > implements it and updates corresponding qemu-iotests cases. > > This series is based on BlockJobType enum QAPI series. > > v5: Address comments from Eric and Paolo: > Add mirror_start_job and front end wrapper. [Paolo] > Base on BlockJobType enum in QAPI. [Eric] > Drop "common" sync mode. [Eric] > > v4: Rewrite to reuse block/mirror.c. > When committing the active layer, the job is internally a mirror job with > type name faked to "commit". > When the job completes, the BDSes are swapped, so the base image become > active and [top, base) dropped. > > > Fam Zheng (6): > mirror: don't close target > mirror: move base to MirrorBlockJob > block: add commit_active_start() > commit: support commit active layer > qemu-iotests: update test cases for commit active > commit: remove unused check > > block/commit.c | 8 +---- > block/mirror.c | 77 +++++++++++++++++++++++++++++++++++++++-------- > blockdev.c | 9 ++++-- > include/block/block_int.h | 22 ++++++++++++-- > qapi-schema.json | 5 +-- > tests/qemu-iotests/040 | 73 +++++++++++++++++++------------------------- > 6 files changed, 125 insertions(+), 69 deletions(-) > Ping?