From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42330)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Veh4e-0003eg-1Y
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 03:05:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Veh4V-0000lc-Ks
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 03:05:47 -0500
Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:41316)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Veh4V-0000lS-Cq
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 03:05:39 -0500
Received: by mail-ee0-f45.google.com with SMTP id l10so182511eei.32
	for <qemu-devel@nongnu.org>; Fri, 08 Nov 2013 00:05:38 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <527C9B4C.9000405@redhat.com>
Date: Fri, 08 Nov 2013 09:05:32 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1383511723-11228-1-git-send-email-marcel.a@redhat.com>
	<CAFe8ug9hauGmXE6GFKa6sRzQ3Thm=RmAh4EQsoYMeOS9j_RyjA@mail.gmail.com>
	<527C023F.2060506@redhat.com>
	<1383859470.2527.64.camel@localhost.localdomain>
	<527C06B5.2020401@redhat.com>
	<1383860314.2527.72.camel@localhost.localdomain>
	<CAFEAcA_0YadtGsKc5qacvwiwR3sK=rtdO6PMaLJfnt+yW-C0Ag@mail.gmail.com>
In-Reply-To: <CAFEAcA_0YadtGsKc5qacvwiwR3sK=rtdO6PMaLJfnt+yW-C0Ag@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] exec: fix regression by making
 system-memory region UINT64_MAX size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>, "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>, qemu-devel <qemu-devel@nongnu.org>, Laszlo Ersek <lersek@redhat.com>, Anthony Liguori <anthony@codemonkey.ws>, Marcel Apfelbaum <marcel.a@redhat.com>, Jordan Justen <jljusten@gmail.com>, afaerber <afaerber@suse.de>, Richard Henderson <rth@twiddle.net>

Il 07/11/2013 22:51, Peter Maydell ha scritto:
>> > 1. Not all architectures have the behavior: "Address space that is not RAM(and friends)
>> >     is for sure PCI". Only x86 behaves like this (I think).
> 
> More specifically, the x86 pc behaves like this. Other
> x86 based systems could in theory behave differently
> (not that we actually model any, I think).

After Marcel's patch, we have changed behavior for at least all boards
that pass get_system_memory() to pci_register_bus or pci_bus_new:

* mips/gt64xxx_pci.c

* pci-host/bonito.c

* pci-host/ppce500.c

* ppc/ppc4xx_pci.c

* sh4/sh_pci.c

These now will not go anymore through unassigned_mem_ops, which is a
behavioral change for MIPS boards (gt64xxx_pci and bonito) at least.

Furthermore, the default behavior of the memory API _is_ read
all-ones/ignore writes, so I'm not sure what's the benefit of adding a
separate region for master abort...

Paolo