From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vej5Q-0006Lz-Kj for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:14:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vej5H-0006GJ-Vi for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:14:44 -0500 Received: from mail-qe0-x231.google.com ([2607:f8b0:400d:c02::231]:46702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vej5H-0006G0-SS for qemu-devel@nongnu.org; Fri, 08 Nov 2013 05:14:35 -0500 Received: by mail-qe0-f49.google.com with SMTP id a11so1660700qen.36 for ; Fri, 08 Nov 2013 02:14:35 -0800 (PST) Sender: Paolo Bonzini Message-ID: <527CB985.8070102@redhat.com> Date: Fri, 08 Nov 2013 11:14:29 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1383859470.2527.64.camel@localhost.localdomain> <1383863039-18875-1-git-send-email-lersek@redhat.com> In-Reply-To: <1383863039-18875-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] reverting commit a53ae8e934cd54686875b5bcfc2f434244ee55d6 Re: [edk2] [PATCH 0/2] Re: exec: fix regression by making system-memory region UINT64_MAX size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: edk2-devel@lists.sourceforge.net Cc: peter.maydell@linaro.org, marcel.a@redhat.com, jan.kiszka@siemens.com, mst@redhat.com, qemu-devel@nongnu.org, jljusten@gmail.com, anthony@codemonkey.ws, Laszlo Ersek , afaerber@suse.de, rth@twiddle.net Il 07/11/2013 23:23, Laszlo Ersek ha scritto: > On 11/07/13 22:24, Marcel Apfelbaum wrote: >> Why pci-hole and system.flash collide? IMHO we should not play with >> priorities here, better solve the collision. > > What about this "beautiful" series? It produces > > memory > 0000000000000000-000fffffffffffff (prio 0, RW): system > [...] > 0000000060000000-00000000ffdfffff (prio 0, RW): alias pci-hole @pci > 0000000060000000-00000000ffdfffff > [...] > 00000000ffe00000-00000000ffffffff (prio 0, R-): system.flash > > and I can run OVMF with it. It also stays within i386/pc. This definitely works, and make sense. But I think for 1.7 we should just revert the commit. It can be done later in 1.8. And it should have a qtest testcase that shows the effect of the patch. Other patches can still be applied to 1.7, but the change definitely had much bigger ramifications than anticipated. The patches are [PATCH for-1.7 v2 5/8] pci: fix address space size for bridge [PATCH for-1.7 v2 7/8] pc: s/INT64_MAX/UINT64_MAX/ [PATCH for-1.7 v2 8/8] spapr_pci: s/INT64_MAX/UINT64_MAX/ There's also [PATCH 1/2] split definitions for exec.c and translate-all.c radix trees [PATCH 2/2] exec: make address spaces 64-bit wide which however has a 2% perf hit for TCG. In 1.8 we can apply it and recover the hit with other optimizations. Paolo