From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38077)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VepfE-0004Px-UW
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 12:16:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vepf8-00077m-S2
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 12:16:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vepf8-00077g-Ka
	for qemu-devel@nongnu.org; Fri, 08 Nov 2013 12:16:02 -0500
Message-ID: <527D1C49.2040005@redhat.com>
Date: Fri, 08 Nov 2013 18:15:53 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1383511723-11228-1-git-send-email-marcel.a@redhat.com>
	<CAFe8ug9hauGmXE6GFKa6sRzQ3Thm=RmAh4EQsoYMeOS9j_RyjA@mail.gmail.com>
	<527D0652.9020805@suse.de> <527D0F29.40802@redhat.com>
	<527D1AD5.10503@suse.de>
In-Reply-To: <527D1AD5.10503@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] exec: fix regression by making
 system-memory region UINT64_MAX size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>, Jan Kiszka <jan.kiszka@siemens.com>, Jordan Justen <jljusten@gmail.com>, rth@twiddle.net

Il 08/11/2013 18:09, Andreas F=C3=A4rber ha scritto:
> I don't have personal experience with using external files there yet,
> but I was hoping that using -pflash pc-bios/bios.bin would just work
> since that'll be symlinked for execution from build directory iiuc.
>=20
> My thinking was the test could then verify that the BIOS does not read
> as all 0xff, whereas Paolo's suggestion sounds more elaborate, ruling
> out actual 0xff within SeaBIOS by having a positive pattern to check fo=
r.

Yeah, that's also a good test and easier!

Paolo