From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44130)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1VfffG-0006s9-8I
	for qemu-devel@nongnu.org; Sun, 10 Nov 2013 19:47:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Vfff5-00050P-Oo
	for qemu-devel@nongnu.org; Sun, 10 Nov 2013 19:47:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:2308)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Vfff5-0004zO-Gh
	for qemu-devel@nongnu.org; Sun, 10 Nov 2013 19:47:27 -0500
Message-ID: <528029C1.6040800@redhat.com>
Date: Mon, 11 Nov 2013 01:50:09 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <CAJOr74jtKZBJOTESjdU+0pmkwY=rC_3_e_-aGaVEfVQWcuoNQg@mail.gmail.com>
In-Reply-To: <CAJOr74jtKZBJOTESjdU+0pmkwY=rC_3_e_-aGaVEfVQWcuoNQg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] dump-guest-memory enhancement.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Phi Debian <phi.debian@gmail.com>
Cc: Dave Anderson <anderson@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On 11/10/13 10:10, Phi Debian wrote:
> Hi All,
> 
> I implemented guest-dump-memory for arm32, and bumped in something
> strange, the PT_LOADs generated from dump.c are not target page
> aligned. There are some advantage to get PT_LOAD aligned.
> 
> This mail is to ask advise about patch I could submit later if wanted.
> 
> Would it be desirable to get the PT_LOAD aligned on target page size
> always, for all arch ?

Can you please explain the problem in more detail? Preferably
illustrated by "readelf" output.

Is it about the placement of the PT_LOAD entries in the core file (eg.
their distance of the beginning of the file, or some such), or about the
contents of the PT_LOAD entries? (Ie. the target-phys ranges they
describe and where those are located in the core file.)

Thanks
Laszlo

> If so I could fix dump.c, but may be people using dump-guest-memory on
> existing current implementation may object, dunno if some of there
> tools (debuggers) are dependent of the non aligned current setup (gdb
> would nt complain)
> 
> If not wanted for existing arch (s390, ppc, i386), may be I could do
> it for arm only.
> 
> Or ultimatly may be this is not wanted at all, in this case I keep my
> dumper for myself :)
> 
> Cheers,
> Phi
>