Re: [Qemu-devel] [PATCH V5 6/6] qemu-iotests: add test for qcow2 snapshot

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013/11/9 4:50, Jeff Cody 写道:
> On Tue, Nov 05, 2013 at 08:01:29AM +0800, Wenchao Xia wrote:
>> This test will focus on the low level procedure of qcow2 snapshot
>> operations, now it covers only the create operation. Overlap error
>> paths are not checked since no good way to trigger those errors.
>>
>> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
>> ---
>>   tests/qemu-iotests/070           |  214 ++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/070.out       |   35 ++++++
>>   tests/qemu-iotests/common.filter |    7 ++
>>   tests/qemu-iotests/group         |    1 +
>>   4 files changed, 257 insertions(+), 0 deletions(-)
>>   create mode 100755 tests/qemu-iotests/070
>>   create mode 100644 tests/qemu-iotests/070.out
>>
>> diff --git a/tests/qemu-iotests/070 b/tests/qemu-iotests/070
>> new file mode 100755
>> index 0000000..37ada84
>> --- /dev/null
>> +++ b/tests/qemu-iotests/070
>> @@ -0,0 +1,214 @@
>> +#!/bin/bash
>> +#
>> +# qcow2 internal snapshot test
>> +#
>> +# Copyright (C) 2013 IBM, Inc.
>> +#
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 2 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +#
>> +owner=xiawenc@linux.vnet.ibm.com
>> +
>> +seq=`basename $0`
>> +echo "QA output created by $seq"
>> +
>> +here=`pwd`
>> +tmp=/tmp/$$
>> +status=1	# failure is the default!
>> +
>> +_cleanup()
>> +{
>> +    _cleanup_test_img
>> +    rm $TEST_DIR/blkdebug.conf
>
> $TEST_DIR needs quoting (also in later uses in this file as well)
>
>> +}
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +# get standard environment, filters and checks
>> +. ./common.rc
>> +. ./common.filter
>> +. ./common.pattern
>> +
>> +# only test qcow2
>> +_supported_fmt qcow2
>> +_supported_proto generic
>> +# bind the errno correctly and filter the output of image check and qemu-img,
>> +# if you want to run it on other OS
>> +_supported_os Linux
>> +
>> +
>> +IMGOPTS="compat=1.1"
>> +
>> +CLUSTER_SIZE=65536
>> +
>> +SIZE=1G
>> +
>> +BLKDBG_TEST_IMG="blkdebug:$TEST_DIR/blkdebug.conf:$TEST_IMG"
>> +
>> +errno=5
>> +
>> +once=on
>> +
>> +imm=off
>> +
>> +
>> +# Start test, note that the injected errors are related to qcow2's snapshot
>> +# logic closely, see qcow2-snapshot.c for more details.
>> +
>> +# path 1: fail in L1 table allocation for snapshot
>> +echo
>> +echo "Path 1: fail in allocation of L1 table"
>> +
>> +_make_test_img $SIZE
>> +
>> +cat > $TEST_DIR/blkdebug.conf <<EOF
>> +[inject-error]
>> +event = "cluster_alloc"
>> +errno = "$errno"
>> +immediately = "$imm"
>> +once = "$once"
>> +EOF
>> +
>> +$QEMU_IMG snapshot -c snap1 $BLKDBG_TEST_IMG
>> +$QEMU_IMG snapshot -l $TEST_IMG
>
> Both $BLKDB_TEST_IMG and $TEST_IMG need quoting (also in later uses in
> this file)
>

  will fix that.