From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55633)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Vfqns-0003z0-N5
	for qemu-devel@nongnu.org; Mon, 11 Nov 2013 07:41:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Vfqnm-0004mq-HD
	for qemu-devel@nongnu.org; Mon, 11 Nov 2013 07:41:16 -0500
Message-ID: <5280D061.50802@suse.de>
Date: Mon, 11 Nov 2013 13:41:05 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1384155875-26999-1-git-send-email-aik@ozlabs.ru>
	<1384155875-26999-5-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1384155875-26999-5-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo
	command line agruments
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Alexander Graf <agraf@suse.de>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-ppc@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Igor Mammedov <imammedo@redhat.com>

Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy:
> This converts +foo/-foo to "foo=3Don"/"foo=3Doff" respectively when
> QEMU parser is used for the command line options.
>=20
> "-cpu" parsers in x86 and other architectures should be unaffected
> by this change.
>=20
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  util/qemu-option.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index efcb5dc..6c8667c 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -890,6 +890,12 @@ static int opts_do_parse(QemuOpts *opts, const cha=
r *params,
>                  if (strncmp(option, "no", 2) =3D=3D 0) {
>                      memmove(option, option+2, strlen(option+2)+1);
>                      pstrcpy(value, sizeof(value), "off");
> +                } else if (strncmp(option, "-", 1) =3D=3D 0) {
> +                    memmove(option, option+1, strlen(option+1)+1);
> +                    pstrcpy(value, sizeof(value), "off");
> +                } else if (strncmp(option, "+", 1) =3D=3D 0) {
> +                    memmove(option, option+1, strlen(option+1)+1);
> +                    pstrcpy(value, sizeof(value), "on");
>                  } else {
>                      pstrcpy(value, sizeof(value), "on");
>                  }

This looks like an interesting idea! However this is much too big a
change to just CC ppc folks on...

Jan, I wonder if this might break slirp's hostfwd option?

Not sure what other options potentially starting with '-' might be
affected. Test cases would be a helpful way of demonstrating that this
change does not have undesired side effects.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg