From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VfqzM-0007wN-A8 for qemu-devel@nongnu.org; Mon, 11 Nov 2013 07:53:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VfqzG-0007wM-5R for qemu-devel@nongnu.org; Mon, 11 Nov 2013 07:53:08 -0500 Message-ID: <5280D329.8000507@siemens.com> Date: Mon, 11 Nov 2013 13:52:57 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1384155875-26999-1-git-send-email-aik@ozlabs.ru> <1384155875-26999-5-git-send-email-aik@ozlabs.ru> <5280D061.50802@suse.de> In-Reply-To: <5280D061.50802@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 4/6] qemu-option: support +foo/-foo command line agruments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Igor Mammedov , qemu-ppc@nongnu.org, Alexander Graf , Anthony Liguori , Luiz Capitulino On 2013-11-11 13:41, Andreas F=E4rber wrote: > Am 11.11.2013 08:44, schrieb Alexey Kardashevskiy: >> This converts +foo/-foo to "foo=3Don"/"foo=3Doff" respectively when >> QEMU parser is used for the command line options. >> >> "-cpu" parsers in x86 and other architectures should be unaffected >> by this change. >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> util/qemu-option.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/util/qemu-option.c b/util/qemu-option.c >> index efcb5dc..6c8667c 100644 >> --- a/util/qemu-option.c >> +++ b/util/qemu-option.c >> @@ -890,6 +890,12 @@ static int opts_do_parse(QemuOpts *opts, const ch= ar *params, >> if (strncmp(option, "no", 2) =3D=3D 0) { >> memmove(option, option+2, strlen(option+2)+1); >> pstrcpy(value, sizeof(value), "off"); >> + } else if (strncmp(option, "-", 1) =3D=3D 0) { >> + memmove(option, option+1, strlen(option+1)+1); >> + pstrcpy(value, sizeof(value), "off"); >> + } else if (strncmp(option, "+", 1) =3D=3D 0) { >> + memmove(option, option+1, strlen(option+1)+1); >> + pstrcpy(value, sizeof(value), "on"); >> } else { >> pstrcpy(value, sizeof(value), "on"); >> } >=20 > This looks like an interesting idea! However this is much too big a > change to just CC ppc folks on... >=20 > Jan, I wonder if this might break slirp's hostfwd option? hostfwd starts with ":" in the simplest case - or what pattern do you have in mind? Jan >=20 > Not sure what other options potentially starting with '-' might be > affected. Test cases would be a helpful way of demonstrating that this > change does not have undesired side effects. >=20 > Regards, > Andreas >=20 --=20 Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux