From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgGoD-0001Z9-BA for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:27:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgGo5-0003rc-Ai for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:27:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgGo5-0003rS-2f for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:27:13 -0500 Message-ID: <52825783.7070401@redhat.com> Date: Tue, 12 Nov 2013 17:29:55 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1384264707-9947-1-git-send-email-imammedo@redhat.com> <1384264707-9947-2-git-send-email-imammedo@redhat.com> In-Reply-To: <1384264707-9947-2-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] pc: map PCI address space as catchall region for not mapped addresses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, afaerber@suse.de On 11/12/13 14:58, Igor Mammedov wrote: > From: "Michael S. Tsirkin" > > With a help of negative memory region priority PCI address space > is mapped underneath RAM regions effectively catching every access > to addresses not mapped by any other region. > It simplifies PCI address space mapping into system address space. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Igor Mammedov > --- > hw/i386/pc.c | 20 ++++++-------------- > hw/i386/pc_piix.c | 2 -- > hw/pci-host/piix.c | 26 ++++---------------------- > hw/pci-host/q35.c | 27 +++++---------------------- > include/hw/i386/pc.h | 14 ++------------ > include/hw/pci-host/q35.h | 2 -- > 6 files changed, 17 insertions(+), 74 deletions(-) Tested with OVMF running from flash (and storing nvvars there). Also tested with my pending series "i440fx-test: check firmware visibility" (reviews welcome :)). GTest: result: OK GTest: run: /i440fx/firmware/bios (MSG: qemu cmdline: -S -display none -bios /tmp/fw_blob_UAGE6W) GTest: result: OK GTest: run: /i440fx/firmware/pflash (MSG: qemu cmdline: -S -display none -pflash /tmp/fw_blob_DHXN6W) GTest: result: OK Tested-by: Laszlo Ersek Thanks! Laszlo