From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgH24-0007lu-Cf for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:41:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgH1w-0003s6-Px for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:41:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39410 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgH1w-0003rG-Jp for qemu-devel@nongnu.org; Tue, 12 Nov 2013 11:41:32 -0500 Message-ID: <52825A38.4080106@suse.de> Date: Tue, 12 Nov 2013 17:41:28 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1383638143-11812-1-git-send-email-zxq_yx_007@163.com> <1383638143-11812-3-git-send-email-zxq_yx_007@163.com> <1383639922.556.10.camel@G08FNSTD131468> <5278B1A3.40109@163.com> <528055EC.6080600@163.com> <1384219693.29198.19.camel@G08FNSTD131468> <52818A38.50500@163.com> <1384225361.29198.51.camel@G08FNSTD131468> In-Reply-To: <1384225361.29198.51.camel@G08FNSTD131468> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/4] apic: QOM'ify apic & icc_bus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan Cc: =?UTF-8?B?6LW15bCP5by6?= , pbonzini@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com Am 12.11.2013 04:02, schrieb Chen Fan: > On Tue, 2013-11-12 at 09:54 +0800, =E8=B5=B5=E5=B0=8F=E5=BC=BA wrote: >> He asked me to drop the parent_realize. so in v2, I just replace the >> 'init' with 'realize'. >> > Hmm=EF=BC=8CI'm confused, Go through the entire QEMU source code, there= was no > DeviceRealize realize field in leaf child, I think Andreas's purpose fo= r > you was not simple to replace the 'init' by 'realize'. Maybe I'm > mistaken, I hope Andreas could give some comments about this. I was serious about that. It appears that my earlier reply didn't arrive on the list, so I resent it today, hope that sheds some light. My virtio series had been reworked in the same fashion but is *still* in need of sending to the list... > on the other hand, I feel good regarding refactor QOM'ify apic, I'm now > making adding 'cpu-del' supported patches. which need unrealize the api= c > device. so please rebase your work on Andreas's git source: > git://github.com/afaerber/qemu-cpu.git qom-cpu. > then we can do for them together. Actually the only pending work is Igor's x86 properties on qom-cpu-next as of now. Both qom-cpu and qom-next have recently been merged so should be no different from upstream qemu.git. The QOM device refactorings are usually taking place on qom-next branch at the same repository. We'll have to see how that works out with the CPU work - ideally I'd merge qom-next first, then continue on qom-cpu. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg