From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1VgJYh-0003g2-Ed
	for qemu-devel@nongnu.org; Tue, 12 Nov 2013 14:23:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1VgJYb-0007S7-Rj
	for qemu-devel@nongnu.org; Tue, 12 Nov 2013 14:23:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47092)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1VgJYb-0007Rs-I1
	for qemu-devel@nongnu.org; Tue, 12 Nov 2013 14:23:25 -0500
Message-ID: <52828029.3020501@redhat.com>
Date: Tue, 12 Nov 2013 12:23:21 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <c66f8b4405fbe3d1ad36d85392bbc556c7959774.1384254624.git.avi@cloudius-systems.com>
In-Reply-To: <c66f8b4405fbe3d1ad36d85392bbc556c7959774.1384254624.git.avi@cloudius-systems.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="V0aSxqHCNWcCllNTujctGQgJCNOLixULc"
Subject: Re: [Qemu-devel] [PATCH] build: set up capabilities on
	qemu-bridge-helper
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@cloudius-systems.com>, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--V0aSxqHCNWcCllNTujctGQgJCNOLixULc
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 11/12/2013 04:10 AM, Avi Kivity wrote:
> Out-of-the-box, 'make install' sets up an unusable qemu-bridge-helper s=
ince
> it doesn't have the required capabilities.
>=20
> Fix by adding them.
>=20
> Note: this may break installing as non-root.  This is actually the righ=
t
> thing to do, since not setting up the capability would result in a brok=
en
> setup.  Perhaps we need a configure flag to disable helpers.
>=20

> +++ b/rules.mak
> @@ -177,3 +177,5 @@ $(shell mkdir -p $(sort $(foreach var,$(nested-vars=
),$(dir $($(var))))))
>  $(foreach var,$(nested-vars), $(eval \
>    -include $(addsuffix *.d, $(sort $(dir $($(var)))))))
>  endef
> +
> +SETCAP =3D setcap
> \ No newline at end of file

Is this intentional?

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--V0aSxqHCNWcCllNTujctGQgJCNOLixULc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJSgoApAAoJEKeha0olJ0NqLqcH/AwzyAdW+dVT5AO8D/TKffzT
nq/dQ2XlaYPTqVvuLWBGHIixhZppYVJ+79UxFT6ej59uesN1L0Y4mNEdPWNwyjCX
H7PrdNAk8bNtCeqqo/L2Nue1ZhUx5DJhsW8FabanVRtDG82EDVT+M+EcG605WVbg
psqyABvLwShzx68dBFpPA6NtCpfoy+vErmozys7Q/hjera7lVLxMN9mk9ezcpdej
ocu0t073pC3ougIGERTDChnFZA97qXY/5wdYMCcKuEYZfkzvArGikmwNkOlfa4OM
JNs/x2M7UWFO6tObraujIBKWjTwpyQaU2Ypq9SjDDTRXoMquXrw+GwFrwtQxtA0=
=3kfV
-----END PGP SIGNATURE-----

--V0aSxqHCNWcCllNTujctGQgJCNOLixULc--