From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45771) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgbBo-0000Vw-Im for qemu-devel@nongnu.org; Wed, 13 Nov 2013 09:13:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgbBi-0008Bl-Jh for qemu-devel@nongnu.org; Wed, 13 Nov 2013 09:13:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgbBi-0008BT-BU for qemu-devel@nongnu.org; Wed, 13 Nov 2013 09:12:58 -0500 Message-ID: <5283898B.4050600@redhat.com> Date: Wed, 13 Nov 2013 15:15:39 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1384334593-9664-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1384334593-9664-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] curses: fixup SIGWINCH handler mess List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Anthony Liguori On 11/13/13 10:23, Gerd Hoffmann wrote: > Don't run code in the signal handler, only set a flag. > Use sigaction(2) to avoid non-portable signal(2) semantics. > Make #ifdefs less messy. > > Signed-off-by: Gerd Hoffmann > --- > ui/curses.c | 44 ++++++++++++++++++++++++++++---------------- > 1 file changed, 28 insertions(+), 16 deletions(-) Compared it with v1. Reviewed-by: Laszlo Ersek