From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VghBw-0002Nn-3f for qemu-devel@nongnu.org; Wed, 13 Nov 2013 15:37:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VghBr-0005g8-1u for qemu-devel@nongnu.org; Wed, 13 Nov 2013 15:37:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VghBq-0005g1-Pm for qemu-devel@nongnu.org; Wed, 13 Nov 2013 15:37:30 -0500 Message-ID: <5283E303.6060302@redhat.com> Date: Wed, 13 Nov 2013 13:37:23 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384338584-14065-1-git-send-email-famz@redhat.com> <1384338584-14065-3-git-send-email-famz@redhat.com> <20131113141924.GF2633@dhcp-200-207.str.redhat.com> In-Reply-To: <20131113141924.GF2633@dhcp-200-207.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="juS31uvWnb0itGijKi2osN7XoKLBuAQQx" Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Fam Zheng Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --juS31uvWnb0itGijKi2osN7XoKLBuAQQx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/13/2013 07:19 AM, Kevin Wolf wrote: >> # >> -# @dirty: #optional dirty bitmap information (only present if the dir= ty >> -# bitmap is enabled) >> +# @dirty-bitmaps: #optional dirty bitmaps information (only present i= f the >> +# driver has one or more dirty bitmaps) >> # >> # @io-status: #optional @BlockDeviceIoStatus. Only present if the dev= ice >> # supports it and the VM is configured to stop on errors >> @@ -963,7 +963,7 @@ >> 'data': {'device': 'str', 'type': 'str', 'removable': 'bool', >> 'locked': 'bool', '*inserted': 'BlockDeviceInfo', >> '*tray_open': 'bool', '*io-status': 'BlockDeviceIoStatus',= >> - '*dirty': 'BlockDirtyInfo' } } >> + '*dirty-bitmaps': ['BlockDirtyInfo'] } } >> =20 >> ## >> # @query-block: >=20 > I believe this is of limited use; if you ever have more than one dirty > bitmap, we're lacking information to associate it with the job it > belongs to. One option would be to extend BlockDirtyInfo to indicate > this, but another might be to actually extend other commands like > query-block-jobs to return information on the dirty bitmap associated > with a specific job. >=20 > I've applied it to block-next anyway, we still have some time to > reconsider for 1.8. Indeed, expanding the per-job query output to list a single dirty bitmap tied to that job is probably more useful than listing all dirty bitmaps without context here. Since it's output-only, and marked optional, we can still withdraw this output even after 1.8 if we decide we don't like it and no one has reported wanting to use it. I was going to suggest _always_ outputting dirty-bitmaps, even if it is an empty array, if that makes it easier to detect that yes, this is a version of qemu new enough to have per-job dirty bitmaps but there are no jobs at the moment; on the other hand, doing that would mean the field is not marked optional, and then we would always have to output it for back-compat reasons. So keeping the field marked optional makes sens= e. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --juS31uvWnb0itGijKi2osN7XoKLBuAQQx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSg+MDAAoJEKeha0olJ0Nqw98H/iPhYZWsntulGSF3RMYoykIM uinCLwXh+3OkJ30DR/MVAc3f1Seh+4IFuPrJNo5m7gudn85P6wQmRdSK60dmCTVF rR8Js4FNREcGCV3kJII65psqUS2LobYq1CxM4uhdtVjBDLFw+L4sRrly3aupUKZo NIJ+CItbV9xXjk4aaHRF8PIcIPE75gjoUSOr+GmkfRvctEWKjcvNiWPsWEkEctLW 0unOVGuorIh61UkDuHUzuV058As67DRM1gIwqhU9FbqOovWpelPLKcYpMJtsBNtg AEN59GbomAWG3WPQn3mrC+9AijUTjVptD1UiQjeVTrmv72cQOiJbjQRhSG3Z1/Y= =tuHl -----END PGP SIGNATURE----- --juS31uvWnb0itGijKi2osN7XoKLBuAQQx--