From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55961) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VghIq-0004r5-GT for qemu-devel@nongnu.org; Wed, 13 Nov 2013 15:44:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VghIl-0007mc-GH for qemu-devel@nongnu.org; Wed, 13 Nov 2013 15:44:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VghIl-0007mT-6D for qemu-devel@nongnu.org; Wed, 13 Nov 2013 15:44:39 -0500 Message-ID: <5283E4B1.7040908@redhat.com> Date: Wed, 13 Nov 2013 13:44:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384338584-14065-1-git-send-email-famz@redhat.com> <1384338584-14065-3-git-send-email-famz@redhat.com> In-Reply-To: <1384338584-14065-3-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AldtHP5RJRecPxNmRlW2wmJPMSUHXgVTA" Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AldtHP5RJRecPxNmRlW2wmJPMSUHXgVTA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/13/2013 03:29 AM, Fam Zheng wrote: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. >=20 > Signed-off-by: Fam Zheng > --- > block.c | 20 ++++++++++++++++++++ > block/qapi.c | 5 +++++ > include/block/block.h | 1 + > qapi-schema.json | 6 +++--- > 4 files changed, 29 insertions(+), 3 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -948,8 +948,8 @@ > # @tray_open: #optional True if the device has a tray and it is open > # (only present if removable is true) > # > -# @dirty: #optional dirty bitmap information (only present if the dirt= y > -# bitmap is enabled) > +# @dirty-bitmaps: #optional dirty bitmaps information (only present if= the > +# driver has one or more dirty bitmaps) Worth adding a '(since 1.8)' designator (may have to be in a followup patch, since Kevin already put it in his staging tree) Also, we have an odd mix of tray_open and dirty-bitmaps (but that mix was already there with io-status); more reason that we should eventually add a patch for treating - and _ as synonyms in QMP keys. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AldtHP5RJRecPxNmRlW2wmJPMSUHXgVTA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSg+SxAAoJEKeha0olJ0NqEP0H/jXBggcY3MvzN0FDHxZs3hc0 hKyX51rgw+NdcE1C7lhAl5Q9RlIVKJrkVWltF3HH+AsD3ThsD0PnbWGHJNsn0lVj k+9cw7E3eMwZZI1B7JLZaOSVdsjRY3BfArZ6jOLvm0i+ywLh3cz4ke/6X2Y/8Da6 OZLN0h2INT40a4QGqpzYNYpArpMbYbwnTki0lfIC/Z1hat1FnJ725b8r30ngzJE9 YPgq5BP0L3D/D3p5Qz/zhqlx0pmVbSrUOdp9DLjsVXJpNPwXglv4YlIwa8oiPBFN 5x680Vebg1uOEU+idLCZ/4gjSxH/aIAvDpFA6DhyO1aZ2yMVO7XO5vgj4oE1iIY= =/Fgq -----END PGP SIGNATURE----- --AldtHP5RJRecPxNmRlW2wmJPMSUHXgVTA--