qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
	"Benoît Canet" <benoit.canet@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list
Date: Thu, 14 Nov 2013 09:39:59 +0800	[thread overview]
Message-ID: <528429EF.9090709@redhat.com> (raw)
In-Reply-To: <528427F6.2000503@linux.vnet.ibm.com>

On 2013年11月14日 09:31, Wenchao Xia wrote:
>
>> --- a/qapi-schema.json
>> +++ b/qapi-schema.json
>> @@ -948,8 +948,8 @@
>>   # @tray_open: #optional True if the device has a tray and it is open
>>   #             (only present if removable is true)
>>   #
>> -# @dirty: #optional dirty bitmap information (only present if the dirty
>> -#         bitmap is enabled)
>> +# @dirty-bitmaps: #optional dirty bitmaps information (only present
>> if the
>> +#                 driver has one or more dirty bitmaps)
>>   #
>>   # @io-status: #optional @BlockDeviceIoStatus. Only present if the
>> device
>>   #             supports it and the VM is configured to stop on errors
>> @@ -963,7 +963,7 @@
>>     'data': {'device': 'str', 'type': 'str', 'removable': 'bool',
>>              'locked': 'bool', '*inserted': 'BlockDeviceInfo',
>>              '*tray_open': 'bool', '*io-status': 'BlockDeviceIoStatus',
>> -           '*dirty': 'BlockDirtyInfo' } }
>> +           '*dirty-bitmaps': ['BlockDirtyInfo'] } }
>>
>>   ##
>>   # @query-block:
>>
>    An old member is removed, is there a compatiable issue for user?
>

We discussed this in v2 thread and the conclusion is no:

http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg01446.html

Fam

  reply	other threads:[~2013-11-14  2:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 10:29 [Qemu-devel] [PATCH v3 0/2] block: per caller dirty bitmap Fam Zheng
2013-11-13 10:29 ` [Qemu-devel] [PATCH v3 1/2] " Fam Zheng
2013-11-13 14:33   ` Fam Zheng
2013-11-13 14:36     ` Kevin Wolf
2013-11-13 10:29 ` [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list Fam Zheng
2013-11-13 14:19   ` Kevin Wolf
2013-11-13 14:40     ` Paolo Bonzini
2013-11-13 14:40     ` Fam Zheng
2013-11-14  2:13       ` Wenchao Xia
2013-11-14  2:22         ` Fam Zheng
2013-11-13 20:37     ` Eric Blake
2013-11-13 20:44   ` Eric Blake
2013-11-14  2:33     ` [Qemu-devel] [PATCH] qapi: Add (Since 1.8) to BlockInfo.dirty-bitmaps Fam Zheng
2013-11-14 12:19       ` Kevin Wolf
2013-11-14  1:31   ` [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list Wenchao Xia
2013-11-14  1:39     ` Fam Zheng [this message]
2013-11-14  2:03     ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528429EF.9090709@redhat.com \
    --to=famz@redhat.com \
    --cc=benoit.canet@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).