From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgmH5-0001ob-Mf for qemu-devel@nongnu.org; Wed, 13 Nov 2013 21:03:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgmH1-0008Vp-Bn for qemu-devel@nongnu.org; Wed, 13 Nov 2013 21:03:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgmH1-0008VG-3c for qemu-devel@nongnu.org; Wed, 13 Nov 2013 21:03:11 -0500 Message-ID: <52842F57.3050209@redhat.com> Date: Wed, 13 Nov 2013 19:03:03 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384338584-14065-1-git-send-email-famz@redhat.com> <1384338584-14065-3-git-send-email-famz@redhat.com> <528427F6.2000503@linux.vnet.ibm.com> In-Reply-To: <528427F6.2000503@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mSu7eNPrxhBuF0x0XpNFpRXEFVIwaPAOR" Subject: Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mSu7eNPrxhBuF0x0XpNFpRXEFVIwaPAOR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/13/2013 06:31 PM, Wenchao Xia wrote: >=20 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -948,8 +948,8 @@ >> # @tray_open: #optional True if the device has a tray and it is open= >> # (only present if removable is true) >> # >> -# @dirty: #optional dirty bitmap information (only present if the dir= ty >> -# bitmap is enabled) >> +# @dirty-bitmaps: #optional dirty bitmaps information (only present >> if the >> +# driver has one or more dirty bitmaps) >> # >> # @io-status: #optional @BlockDeviceIoStatus. Only present if the >> device >> # supports it and the VM is configured to stop on errors= >> @@ -963,7 +963,7 @@ >> 'data': {'device': 'str', 'type': 'str', 'removable': 'bool', >> 'locked': 'bool', '*inserted': 'BlockDeviceInfo', >> '*tray_open': 'bool', '*io-status': 'BlockDeviceIoStatus'= , >> - '*dirty': 'BlockDirtyInfo' } } >> + '*dirty-bitmaps': ['BlockDirtyInfo'] } } >> >> ## >> # @query-block: >> > An old member is removed, is there a compatiable issue for user? We already answered this; there is no back-compat issue with removing a variable that is already marked optional and which is used in an output-only type: https://lists.gnu.org/archive/html/qemu-devel/2013-11/msg01446.html --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mSu7eNPrxhBuF0x0XpNFpRXEFVIwaPAOR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJShC9XAAoJEKeha0olJ0NqYckIAKwEDZO4/gUG23Z/1Bdg7S0w 0KEPDOsEfEfAnqVm8Q03q6fVz77le5xtAHfViBjOov/O7B7NMQoebY3nTk3WjT0B jkMNmgF8xm+puPR3vcTUMsJ7eHjYqTZ7f51P2foXG4NOmz0g6WljLRFDMlzg51bj ka9KazctmapKpyCNNuPzxY2YYm6o5PxXmI0Vy8fXMlWVpr1fBxDhebzjmx26s1Wc B7erJyN8hiSQTdjvKlAa4rKSbStGOm62WVoffUqEOxhbA4+LzXYhLeaF3gluFWQG A0b5sOyFXEudVi59xoJSCOqoMxbyg+1qUZ/qzC61sBAMo28MP9QXd03t+8LVBeM= =Gl2+ -----END PGP SIGNATURE----- --mSu7eNPrxhBuF0x0XpNFpRXEFVIwaPAOR--