qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] make all Python scripts executable
Date: Tue, 4 Feb 2020 19:18:21 +0100	[thread overview]
Message-ID: <5284e650-1245-e982-57cd-9cd1971ef7cb@redhat.com> (raw)
In-Reply-To: <20200204160237.16889-1-pbonzini@redhat.com>

On 2/4/20 5:02 PM, Paolo Bonzini wrote:
> Scripts that have a Python shebang are meant to be executed directly from the
> shell; give them 755 permissions.

Ah I should have done the chmod in my "Explicit usage of Python 3 
(scripts with __main__)" patches, but I would have missed 
scripts/signrom.py and tests/qemu-iotests/222.

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> Based-on: <20200204160028.16211-1-pbonzini@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   scripts/minikconf.py   | 0
>   scripts/signrom.py     | 0
>   tests/qemu-iotests/222 | 0
>   tests/qemu-iotests/245 | 0
>   4 files changed, 0 insertions(+), 0 deletions(-)
>   mode change 100644 => 100755 scripts/minikconf.py
>   mode change 100644 => 100755 scripts/signrom.py
>   mode change 100644 => 100755 tests/qemu-iotests/222
>   mode change 100644 => 100755 tests/qemu-iotests/245
> 
> diff --git a/scripts/minikconf.py b/scripts/minikconf.py
> old mode 100644
> new mode 100755
> diff --git a/scripts/signrom.py b/scripts/signrom.py
> old mode 100644
> new mode 100755
> diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> old mode 100644
> new mode 100755
> diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
> old mode 100644
> new mode 100755
> 

Thanks, patch applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next



      reply	other threads:[~2020-02-04 18:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 16:02 [PATCH] make all Python scripts executable Paolo Bonzini
2020-02-04 18:18 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5284e650-1245-e982-57cd-9cd1971ef7cb@redhat.com \
    --to=philmd@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).