From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VhL3X-0000fh-3w for qemu-devel@nongnu.org; Fri, 15 Nov 2013 10:11:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VhL3M-0002Ob-2P for qemu-devel@nongnu.org; Fri, 15 Nov 2013 10:11:35 -0500 Message-ID: <52863995.2070007@suse.de> Date: Fri, 15 Nov 2013 16:11:17 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1384492469-11881-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1384492469-11881-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id and CPUState::kvm_cpu_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Alexander Graf , Bharat Bhushan , qemu-ppc@nongnu.org, Paolo Bonzini , Scott Wood , Paul Mackerras Am 15.11.2013 06:14, schrieb Alexey Kardashevskiy: > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index 7739e00..52fc76d 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h > @@ -197,6 +197,7 @@ struct CPUState { > bool kvm_vcpu_dirty; > struct KVMState *kvm_state; > struct kvm_run *kvm_run; > + int kvm_cpu_id; > =20 > /* TODO Move common fields from CPUArchState here. */ > int cpu_index; /* used by alpha TCG */ Here you are adding a field to CPUState, fine with me. (Please add a documentation line above the struct then.) > diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h > index bb84767..8052f6b 100644 > --- a/target-ppc/cpu.h > +++ b/target-ppc/cpu.h > @@ -1074,6 +1074,9 @@ struct CPUPPCState { > */ > uint8_t fit_period[4]; > uint8_t wdt_period[4]; > + > + /* The CPU index used in the device tree. KVM uses this index too = */ > + int cpu_dt_id; But I believe I have requested a number of times not to add random fields to CPUPPCState unless they are accessed by TCG. Please place the new field in PowerPCCPU instead and put the description into the struct documentation. > }; > =20 > #define SET_FIT_PERIOD(a_, b_, c_, d_) \ > @@ -2154,4 +2157,8 @@ static inline bool cpu_has_work(CPUState *cpu) > =20 > void dump_mmu(FILE *f, fprintf_function cpu_fprintf, CPUPPCState *env)= ; > =20 > +int ppc_get_vcpu_dt_id(CPUState *cs); > +CPUState *ppc_get_vcpu_by_dt_id(int cpu_dt_id); > +void ppc_fixup_cpu_dt_id(PowerPCCPU *cpu); > + > #endif /* !defined (__CPU_PPC_H__) */ Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg