From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44371)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vyasevic@redhat.com>) id 1VhLJQ-00023s-T9
	for qemu-devel@nongnu.org; Fri, 15 Nov 2013 10:28:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vyasevic@redhat.com>) id 1VhLJK-0007ZD-SL
	for qemu-devel@nongnu.org; Fri, 15 Nov 2013 10:28:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:3874)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vyasevic@redhat.com>) id 1VhLJK-0007Z8-CS
	for qemu-devel@nongnu.org; Fri, 15 Nov 2013 10:27:54 -0500
Message-ID: <52863D75.4020307@redhat.com>
Date: Fri, 15 Nov 2013 10:27:49 -0500
From: Vlad Yasevich <vyasevic@redhat.com>
MIME-Version: 1.0
References: <20131114103753.GA15291@redhat.com>
In-Reply-To: <20131114103753.GA15291@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] pc: add 1.8 machine type
Reply-To: vyasevic@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Eduardo Habkost <ehabkost@redhat.com>, Anthony Liguori <aliguori@amazon.com>, qemu-devel@nongnu.org

On 11/14/2013 05:37 AM, Michael S. Tsirkin wrote:

>
> -#define PC_Q35_1_7_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS
> +#define PC_Q35_1_8_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS
> +
> +static QEMUMachine pc_q35_machine_v1_8 = {
> +    PC_Q35_1_8_MACHINE_OPTIONS,
> +    .name = "pc-q35-1.8",
> +    .alias = "q35",
> +    .init = pc_q35_init,
> +};
> +
> +#define PC_Q35_1_7_MACHINE_OPTIONS PC_Q35_1_8_MACHINE_OPTIONS
>
>   static QEMUMachine pc_q35_machine_v1_7 = {
>       PC_Q35_1_7_MACHINE_OPTIONS,
>       .name = "pc-q35-1.7",
>       .alias = "q35",
> -    .init = pc_q35_init,
> +    .init = pc_q35_init_1_7,
>   };
>
Hi Michael

Shouldn't the '.alias' be removed from the 1.7 machine?

Thanks
-vlad

> -#define PC_Q35_1_6_MACHINE_OPTIONS PC_Q35_MACHINE_OPTIONS
> +#define PC_Q35_1_6_MACHINE_OPTIONS PC_Q35_1_7_MACHINE_OPTIONS
>
>   static QEMUMachine pc_q35_machine_v1_6 = {
>       PC_Q35_1_6_MACHINE_OPTIONS,
> @@ -313,6 +333,7 @@ static QEMUMachine pc_q35_machine_v1_4 = {
>
>   static void pc_q35_machine_init(void)
>   {
> +    qemu_register_machine(&pc_q35_machine_v1_8);
>       qemu_register_machine(&pc_q35_machine_v1_7);
>       qemu_register_machine(&pc_q35_machine_v1_6);
>       qemu_register_machine(&pc_q35_machine_v1_5);
>