From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54167)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ViKIM-0004Bj-Cj
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 03:35:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ViKID-0003B9-Vh
	for qemu-devel@nongnu.org; Mon, 18 Nov 2013 03:34:58 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5289D122.5040208@redhat.com>
Date: Mon, 18 Nov 2013 09:34:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1384492469-11881-1-git-send-email-aik@ozlabs.ru>
	<5285FA1C.2070707@redhat.com> <5289835E.9040106@ozlabs.ru>
In-Reply-To: <5289835E.9040106@ozlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] ppc: introduce CPUPPCState::cpu_dt_id
	and CPUState::kvm_cpu_id
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, Bharat Bhushan <bharat.bhushan@freescale.com>, qemu-ppc@nongnu.org, Scott Wood <scottwood@freescale.com>, Paul Mackerras <paulus@samba.org>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Il 18/11/2013 04:02, Alexey Kardashevskiy ha scritto:
> On 11/15/2013 09:40 PM, Paolo Bonzini wrote:
>> Il 15/11/2013 06:14, Alexey Kardashevskiy ha scritto:
>>>
>>> It does not feel that we really need CPUState::kvm_cpu_id and
>>> direct calling of kvm_arch_vcpu_id() would be enough.
>>
>> Indeed -- and it should be kvm_ppc_vcpu_id() since other architectures
>> do not need it.
> 
> And ignore kvm_arch_vcpu_id() for spapr/ppc?

Sorry, brain fart - i meant ppc_get_vcpu_dt_id but it has already been
objected to earlier.  So the patch is ok for me, modulo removal of
kvm_cpu_id which you already proposed above.

Paolo