From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViRO7-0004LP-PN for qemu-devel@nongnu.org; Mon, 18 Nov 2013 11:09:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViRO0-0007Ta-0N for qemu-devel@nongnu.org; Mon, 18 Nov 2013 11:09:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:35571 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViRNz-0007TV-Pj for qemu-devel@nongnu.org; Mon, 18 Nov 2013 11:09:15 -0500 Message-ID: <528A3BA8.3030706@suse.de> Date: Mon, 18 Nov 2013 17:09:12 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1384545246-13556-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1384545246-13556-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qtest: Adding -display none to new tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org, stefanha@redhat.com Cc: Paolo Bonzini , Anthony Liguori Hi, Am 15.11.2013 20:54, schrieb Kevin Wolf: > Without it, you either get a window for a short time, or worse, test > failures when 'make check' isn't run in an X session. >=20 > Signed-off-by: Kevin Wolf > --- > tests/blockdev-test.c | 2 +- > tests/qdev-monitor-test.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/blockdev-test.c b/tests/blockdev-test.c > index c940e00..fa49e09 100644 > --- a/tests/blockdev-test.c > +++ b/tests/blockdev-test.c > @@ -20,7 +20,7 @@ static void test_drive_add_empty(void) > const char *response_return; > =20 > /* Start with an empty drive */ > - qtest_start("-drive if=3Dnone,id=3Ddrive0"); > + qtest_start("-display none -drive if=3Dnone,id=3Ddrive0"); [snip] I've been wondering: Can't we just make qtest_start prepend -display none always, so that we don't have to remember to repeatedly add it everywhere? Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg