From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViS5z-0000GH-JL for qemu-devel@nongnu.org; Mon, 18 Nov 2013 11:54:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViS5t-0005R2-Hg for qemu-devel@nongnu.org; Mon, 18 Nov 2013 11:54:43 -0500 Received: from cantor2.suse.de ([195.135.220.15]:37340 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViS5t-0005Qy-AZ for qemu-devel@nongnu.org; Mon, 18 Nov 2013 11:54:37 -0500 Message-ID: <528A4649.2060709@suse.de> Date: Mon, 18 Nov 2013 17:54:33 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1384792594-21102-1-git-send-email-afaerber@suse.de> <20131118164828.GA12155@stefanha-thinkpad.redhat.com> In-Reply-To: <20131118164828.GA12155@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] qtest: Use -display none by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, anthony@codemonkey.ws, "Michael S. Tsirkin" , qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com Am 18.11.2013 17:48, schrieb Stefan Hajnoczi: > On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas F=E4rber wrote: >> This avoids each test needing to add it to suppress windows popping up= . >> >> Signed-off-by: Andreas F=E4rber >> --- >> tests/boot-order-test.c | 2 +- >> tests/endianness-test.c | 6 +++--- >> tests/fw_cfg-test.c | 3 +-- >> tests/hd-geo-test.c | 2 +- >> tests/i440fx-test.c | 2 +- >> tests/libqtest.c | 1 + >> tests/m48t59-test.c | 2 +- >> tests/qom-test.c | 2 +- >> tests/rtc-test.c | 2 +- >> tests/tmp105-test.c | 2 +- >> 10 files changed, 12 insertions(+), 12 deletions(-) >=20 > I avoided making -display none common because tests may wish to have a > display. But at the moment no test needs a display so I guess this is > fine. I was under the assumption that -display none -display sdl would work just like mst's overriding the default -machine accel=3Dqtest with -machine accel=3Dtcg? Anyway, we could choose to go with your less invasive version for 1.7 and apply an adjusted version of this one for 1.8. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg