From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55741)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Vif5A-0005xd-Ej
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 01:46:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Vif52-0004hl-P0
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 01:46:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29799)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1Vif52-0004gN-E4
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 01:46:36 -0500
Message-ID: <528B0944.8000305@redhat.com>
Date: Tue, 19 Nov 2013 14:46:28 +0800
From: Fam Zheng <famz@redhat.com>
MIME-Version: 1.0
References: <1384395844-21926-1-git-send-email-famz@redhat.com>
	<20131118152910.GE4083@stefanha-thinkpad.redhat.com>
	<20131118153812.GC5166@dhcp-200-207.str.redhat.com>
In-Reply-To: <20131118153812.GC5166@dhcp-200-207.str.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add "-c <cache-mode>" to
	check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com

On 2013=E5=B9=B411=E6=9C=8818=E6=97=A5 23:38, Kevin Wolf wrote:
> Am 18.11.2013 um 16:29 hat Stefan Hajnoczi geschrieben:
>> On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote:
>>> The default cache mode for drive options is changed to writethrough, =
and
>>> overridable with "./check -c <mode>".
>>
>> Please make the default "writeback" so that ./check completes more
>> quickly.
>
> Changing the cache mode should be a separate patch.
>
> The current default for all shell script based tests is
> cache=3Dwritethrough (can be overridden with -nocache) and Python test
> cases should respect the same setting.
>
> This is also the problem that I see with this patch: It doesn't make
> '-nocache' an alias of '-c none', but both control different aspects.
> What should happen is that '-c <mode>' sets
>
>      QEMU_IO_OPTIONS=3D"$QEMU_IO_OPTIONS -t <mode>"
>
> like -nocache does today, and the Python scripts should refer to the
> same cache settings as the bash scripts do.
>

Right. Thanks for explaining.

Fam