From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45743)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ViiV1-0004BA-Gx
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 05:25:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ViiUs-0003vH-Rs
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 05:25:39 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <528B3C95.3060009@redhat.com>
Date: Tue, 19 Nov 2013 11:25:25 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1381254296-3203-1-git-send-email-afaerber@suse.de>
	<1381254296-3203-48-git-send-email-afaerber@suse.de>
	<20131118122928.GA23465@amosk.info> <528A25A8.3000301@suse.de>
	<20131119083150.GA16173@amosk.info>
In-Reply-To: <20131119083150.GA16173@amosk.info>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 47/58] qdev-monitor: Unref device when
	device_add fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: qemu-stable@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org

Il 19/11/2013 09:31, Amos Kong ha scritto:
> I can reproduce by hotplugging virtio-net-pci NIC
> 
> for i in `seq 3 9` a b c d e f 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f;do
> for j in `seq 1 7` 0;do
> 
> echo "netdev_add tap,id=dev$i$j" | nc -U /tmp/m
> echo "device_add virtio-net-pci,netdev=dev$i$j,id=nic$i$j,addr=0x$i.$j,multifunction=on" | nc -U /tmp/m
> 
> done
> done

Do you have the full command line?

Also, why/where is device_add failing?  Can you add a puts(driver); before the unrefs?

I tried something very similar to the above, with commands like

netdev_add bridge,helper=/usr/libexec/qemu-bridge-helper,br=virbr0,id=dev1f0
device_add virtio-net-pci,netdev=dev1f0,id=nic1f0,addr=0x1f.0,multifunction=on

and it hotplugged all 224 devices this way without any failure.

Did you try running with MALLOC_PERTURB_=42