From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vikux-0003YQ-Tv for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:00:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vikus-0004Ru-SL for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:00:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vikus-0004RZ-HL for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:00:30 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJD0S3F010610 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Nov 2013 08:00:29 -0500 Message-ID: <528B60E4.7070301@redhat.com> Date: Tue, 19 Nov 2013 06:00:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384759309-1188-1-git-send-email-famz@redhat.com> <528B0A3A.6070303@redhat.com> In-Reply-To: <528B0A3A.6070303@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QGbpvWaQuAiniLSEsEgmQ1UfsaGNVotbQ" Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: Filter out "qemu-io> " in all tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QGbpvWaQuAiniLSEsEgmQ1UfsaGNVotbQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/18/2013 11:50 PM, Fam Zheng wrote: > The second patch is too big in size (over 10M), and rejected by list > moderator. >=20 > You can PULL from git branch: >=20 > https://github.com/famz/qemu.git 035-filter-qemu-io I'm guessing the second patch consists of a tiny amount of code to turn on the filter, while the majority of the patch was automated. It would be helpful to amend your commit message to show how you automated the conversion (was it something like find tests/qemu-iotests -name "*.out" | \ xargs -L1 sed -i "s/qemu-io> //g" ' ?) Given such a formula in the commit message itself, it would be much easier to review the patch - check that both the non-automatic small modification and the conversion formula make sense, then repeat the conversion formula locally and compare it to your git tree to see that the two results match, and that the testsuite still passes. [Or in other words, I don't plan on reading 10M of mindlessly repetitive changes :) ] >> tests/qemu-iotests/common.filter | 3 +- >> 20 files changed, 75546 insertions(+), 75545 deletions(-) Looks like that's the one file with the nontrivial change. diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter index 8e7b1a4..0dd82e1 100644 --- a/tests/qemu-iotests/common.filter +++ b/tests/qemu-iotests/common.filter @@ -149,7 +149,8 @@ _filter_win32() # sanitize qemu-io output _filter_qemu_io() { - _filter_win32 | sed -e "s/[0-9]* ops\; [0-9/:. sec]* ([0-9/.inf]* [EPTGMKiBbytes]*\/sec and [0-9/.inf]* ops\/sec)/X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/" + _filter_win32 | sed -e "s/[0-9]* ops\; [0-9/:. sec]* ([0-9/.inf]* [EPTGMKiBbytes]*\/sec and [0-9/.inf]* ops\/sec)/X ops\; XX:XX:XX.X (XXX YYY\/sec and XXX ops\/sec)/" |\ + sed -e "s/qemu-io> //g" } # replace occurrences of QEMU_PROG with "qemu" Question - why do you pipeline 'sed | sed'? It should be sufficient to just add the "s/qemu-io> //g" instruction into the existing sed pipeline, for one fewer process per filter run. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QGbpvWaQuAiniLSEsEgmQ1UfsaGNVotbQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSi2DlAAoJEKeha0olJ0NqZT8H/Ru3BKARq+Oksocc+E+4xgvX U3/F5F0bQlxvyO844drs0SkteMz+MIbiUU/kqTpAZfWYDVvOsY7TKrvByA0wcxy/ AkTqfwNvDhg7ha5e735enij5jHKMzbkh0ujBNLn/CSMcraSkStPx4BZphAHXGgov 4a9MAGz6lm/2VZyUY4X5DCW7ThTOfNqrTzHxaw3StPctNyz7nZkJ4c6It4D+Usm+ hUUyrgZKHecX/bxGRUZo+uAc49O34Xc848/+hIpJSaT48M+0C2r6bYXcu0JTFbFd Qfb17PQMxbbR6ypyqTDTqnxb/iuCERm4p5S3aNSFwBs3iqR2OkhATy+NTNvJ1gE= =wc2f -----END PGP SIGNATURE----- --QGbpvWaQuAiniLSEsEgmQ1UfsaGNVotbQ--