From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VilFl-0001PW-Cj
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:22:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VilFf-0002hg-Dd
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:22:05 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23624)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VilFf-0002ha-5n
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 08:21:59 -0500
Message-ID: <528B65E6.7040203@redhat.com>
Date: Tue, 19 Nov 2013 14:21:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1379694292-1601-1-git-send-email-pbonzini@redhat.com>	<1379694292-1601-12-git-send-email-pbonzini@redhat.com>
	<528A310A.60607@dlhnet.de> <528A3422.1030701@kamp.de>
	<528A3C4A.4090001@redhat.com> <528B3C86.3030309@kamp.de>
	<528B41A5.1080504@redhat.com> <528B53A6.3030204@kamp.de>
	<528B561C.9070200@redhat.com> <528B5A5B.1090705@kamp.de>
In-Reply-To: <528B5A5B.1090705@kamp.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache
 leaves when -cpu host is used
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit@irqsave.net>

Il 19/11/2013 13:32, Peter Lieven ha scritto:
>>
>> +
>> +        /* We give out APIC IDs ourselves, so force bits 31..26 even
>> for "-cpu host".  */
>> +        if (cs->nr_cores > 1) {
>> +            *eax |= (cs->nr_cores - 1) << 26;
>>           }
>>           break;
>>       case 5:
>
> I already tried exactly this fix. Its reading index 0x0000004 for
> increasing indexes until qemu aborts:

Oops, it should be I guess "if ((*eax & 31) && cs->nr_cores > 1)".

Paolo

> ~/git/qemu$ x86_64-softmmu/qemu-system-x86_64 -m 2048 -drive
> if=virtio,file=iscsi://172.21.200.45/iqn.2001-05.com.equallogic:0-8a0906-9d95c510a-344001d54795289f-2012-r2-1-7-0/0,format=raw,cache=writeback,aio=native
> -cpu host -monitor stdio -vnc :1 -enable-kvm -usb -usbdevice tablet -vga
> cirrus -global virtio-blk-pci.scsi=off -smp
> 4,cores=4,threads=1,sockets=1  -serial null  -parallel null -boot c