From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vinbb-0007sQ-GD for qemu-devel@nongnu.org; Tue, 19 Nov 2013 10:52:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VinbS-0002Dc-CM for qemu-devel@nongnu.org; Tue, 19 Nov 2013 10:52:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VinbS-0002DG-41 for qemu-devel@nongnu.org; Tue, 19 Nov 2013 10:52:38 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJFqaTT030564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Nov 2013 10:52:36 -0500 Message-ID: <528B8943.3010607@redhat.com> Date: Tue, 19 Nov 2013 08:52:35 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384875448-13115-1-git-send-email-kwolf@redhat.com> <1384875448-13115-2-git-send-email-kwolf@redhat.com> In-Reply-To: <1384875448-13115-2-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KHL1tqNbaMLmoPPmnWor297RRlKrEQj6O" Subject: Re: [Qemu-devel] [PATCH 1/2] block: Enable BDRV_O_SNAPSHOT with driver-specific options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KHL1tqNbaMLmoPPmnWor297RRlKrEQj6O Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/19/2013 08:37 AM, Kevin Wolf wrote: > In the case of snapshot=3Don, don't rely on the backing file path in th= e > temporary image any more, but override the backing file with the given > set of options. This way, block drivers that don't use a file name can > be accessed with snapshot=3Don, for example: >=20 > -drive file.driver=3Dnbd,file.host=3Dlocalhost,snapshot=3Don >=20 > Which becomes internally something like: >=20 > file.filename=3D/tmp/vl.AWQZCu,backing.file.driver=3Dnbd,backing.fi= le.host=3Dlocalhost [libvirt isn't using snapshot=3Don, but that doesn't affect the utility o= f this patch] >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 49 +++++++++++++++++++++++-------------------------- > 1 file changed, 23 insertions(+), 26 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KHL1tqNbaMLmoPPmnWor297RRlKrEQj6O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSi4lDAAoJEKeha0olJ0NqCKIIAK8lEbHN2CKCaD+dcHcfjWPr Ql19Ce3RUfoCcXqi8tm2qPE6whcEGQNMevRxpT/FVJGb4y2d1FxrA31cAvRSF2iu cReNzyjNiaU0BWvfg6o1sB4MJSRkBlGPnh/HpVOiC1x//befnt+4eILwo1BaPnUl UW0rX1Ab1cyNDrs+MYQ0KQqgyqHHBrbWZWGio8PZBvCMdA7sizuQsYW8Es05NBNX 0CiB2ojhKj8utFx54090Yt57O9hCKge747r0wbzh5MqJBIG95/YG2kwSej9WMFqr oLgoeGh+s9hjj+5oeh21r06wSrzUfbC8UucpadVCw8COon9nQ7t5MfGj420LIxU= =oCsp -----END PGP SIGNATURE----- --KHL1tqNbaMLmoPPmnWor297RRlKrEQj6O--