From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Bandan Das <bsd@redhat.com>, Michael Tsirkin <mst@redhat.com>,
qemu-stable <qemu-stable@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.7] pci: unregister vmstate_pcibus on unplug
Date: Tue, 19 Nov 2013 18:44:44 +0100 [thread overview]
Message-ID: <528BA38C.4010806@redhat.com> (raw)
In-Reply-To: <528BA0DD.3040902@suse.de>
Il 19/11/2013 18:33, Andreas Färber ha scritto:
> Why? I still think that would be wrong. We had previously discussed with
> Paolo that VMState is global state, which according to Anthony should
> not be registered before realization. So far we have a mix of PCI host
> bridges instantiating PCIBus before or after realization depending on
> whether the bus name needs to depend on the device id or not (with trend
> towards instantiating the PCIBus during instance_init), at which point
> in time the state should not be registered yet. The sketched solution
> was to implement a "realized" property for BusState, so that we can
> decouple vmstate_register() from instantation time rather than moving it
> into instance_init.
I agree. However, this is also a bug fix, and it would be a bit ugly to
tie it to large infrastructure changes (same reason why I want to have
my virtio hotplug/unplug fixes go in _before_ the realize patches, for
example).
With that in mind, Bandan's patch could be good for 1.7.
Paolo
next prev parent reply other threads:[~2013-11-19 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 22:52 [Qemu-devel] [PATCH] pci: unregister vmstate_pcibus on unplug Bandan Das
2013-11-19 12:51 ` [Qemu-devel] [PATCH for-1.7] " Andreas Färber
2013-11-19 13:56 ` Michael S. Tsirkin
2013-11-19 17:03 ` Bandan Das
2013-11-19 17:33 ` Andreas Färber
2013-11-19 17:44 ` Paolo Bonzini [this message]
2013-11-19 17:50 ` Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528BA38C.4010806@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=bsd@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).