From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <stefan.weil@weilnetz.de>
Cc: "zhangmin (S)" <zhangmin6@huawei.com>,
"Wangting (Kathy)" <kathy.wangting@huawei.com>,
Luonengjun <luonengjun@huawei.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Qinling <mail.qinling@huawei.com>,
"Chentao (Boby)" <boby.chen@huawei.com>,
"Wangrui (K)" <moon.wangrui@huawei.com>,
Anthony Liguori <anthony@codemonkey.ws>,
"Wubin (H)" <wu.wubin@huawei.com>
Subject: Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in qemu_put_buffer() is wrong
Date: Tue, 19 Nov 2013 19:07:41 +0100 [thread overview]
Message-ID: <528BA8ED.7000507@redhat.com> (raw)
In-Reply-To: <528BA5F7.4040105@weilnetz.de>
Il 19/11/2013 18:55, Stefan Weil ha scritto:
>>> >> diff --git a/savevm.c b/savevm.c
>>> >> index 2f631d4..3f912dd 100644
>>> >> --- a/savevm.c
>>> >> +++ b/savevm.c
>>> >> @@ -794,7 +794,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size)
>>> >> if (l > size)
>>> >> l = size;
>>> >> memcpy(f->buf + f->buf_index, buf, l);
>>> >> - f->bytes_xfer += size;
>>> >> + f->bytes_xfer += l;
>>> >> if (f->ops->writev_buffer) {
>>> >> add_to_iovec(f, f->buf + f->buf_index, l);
>>> >> }
>>> >> --
>>> >> 1.7.3.1.msysgit.0
>> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Should this patch be included in QEMU 1.7? It's obviously a bug fix, so
> I assume yes.
>
The committer didn't say what it fixes or whether it fixes anything.
But I'd guess it is something related to block migration. In that case
yes, it should be included.
Paolo
next prev parent reply other threads:[~2013-11-19 18:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 5:53 [Qemu-devel] [PATCH] the calculation of bytes_xfer in qemu_put_buffer() is wrong Wangting (Kathy)
2013-11-19 8:19 ` Paolo Bonzini
2013-11-19 17:55 ` [Qemu-devel] [PATCH for-1.7?] " Stefan Weil
2013-11-19 18:07 ` Paolo Bonzini [this message]
2013-11-20 5:28 ` Wangting (Kathy)
2013-11-20 10:37 ` Paolo Bonzini
2013-11-20 11:27 ` [Qemu-devel] [PATCH] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=528BA8ED.7000507@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=boby.chen@huawei.com \
--cc=kathy.wangting@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mail.qinling@huawei.com \
--cc=moon.wangrui@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=stefan.weil@weilnetz.de \
--cc=wu.wubin@huawei.com \
--cc=zhangmin6@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).