From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VipiS-0002Xa-5v
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 13:08:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VipiM-0005c2-60
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 13:08:00 -0500
Received: from mx1.redhat.com ([209.132.183.28]:4758)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VipiL-0005bu-Ty
	for qemu-devel@nongnu.org; Tue, 19 Nov 2013 13:07:54 -0500
Message-ID: <528BA8ED.7000507@redhat.com>
Date: Tue, 19 Nov 2013 19:07:41 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <F5FDBD9C42529D44A051B02D2563D5205628452C@szxema505-mbx.china.huawei.com>
	<528B1F0B.40001@redhat.com> <528BA5F7.4040105@weilnetz.de>
In-Reply-To: <528BA5F7.4040105@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in
 qemu_put_buffer() is wrong
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <stefan.weil@weilnetz.de>
Cc: "zhangmin (S)" <zhangmin6@huawei.com>, "Wangting (Kathy)" <kathy.wangting@huawei.com>, Luonengjun <luonengjun@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Qinling <mail.qinling@huawei.com>, "Chentao (Boby)" <boby.chen@huawei.com>, "Wangrui (K)" <moon.wangrui@huawei.com>, Anthony Liguori <anthony@codemonkey.ws>, "Wubin (H)" <wu.wubin@huawei.com>

Il 19/11/2013 18:55, Stefan Weil ha scritto:
>>> >> diff --git a/savevm.c b/savevm.c
>>> >> index 2f631d4..3f912dd 100644
>>> >> --- a/savevm.c
>>> >> +++ b/savevm.c
>>> >> @@ -794,7 +794,7 @@ void qemu_put_buffer(QEMUFile *f, const uint8_t *buf, int size)
>>> >>          if (l > size)
>>> >>              l = size;
>>> >>          memcpy(f->buf + f->buf_index, buf, l);
>>> >> -        f->bytes_xfer += size;
>>> >> +        f->bytes_xfer += l;
>>> >>          if (f->ops->writev_buffer) {
>>> >>              add_to_iovec(f, f->buf + f->buf_index, l);
>>> >>          }
>>> >> -- 
>>> >> 1.7.3.1.msysgit.0
>> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Should this patch be included in QEMU 1.7? It's obviously a bug fix, so
> I assume yes.
> 

The committer didn't say what it fixes or whether it fixes anything.
But I'd guess it is something related to block migration.  In that case
yes, it should be included.

Paolo