From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VisEX-0008LM-AR for qemu-devel@nongnu.org; Tue, 19 Nov 2013 15:49:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VisES-0000Wa-FM for qemu-devel@nongnu.org; Tue, 19 Nov 2013 15:49:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VisES-0000WL-5x for qemu-devel@nongnu.org; Tue, 19 Nov 2013 15:49:12 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJKnBgY013201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Nov 2013 15:49:11 -0500 Message-ID: <528BCEC6.5020803@redhat.com> Date: Tue, 19 Nov 2013 13:49:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1384697924-16918-1-git-send-email-mreitz@redhat.com> <1384697924-16918-5-git-send-email-mreitz@redhat.com> In-Reply-To: <1384697924-16918-5-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BpnMrkMkmKTdFrwKJt6QitPtuN122iJ9n" Subject: Re: [Qemu-devel] [PATCH 4/4] qcow2: Check validity of backing file name length List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BpnMrkMkmKTdFrwKJt6QitPtuN122iJ9n Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/17/2013 07:18 AM, Max Reitz wrote: > The len variable is a signed integer, therefore it may overflow when > reading the backing file name length from the qcow2 image header. This > case should be handled explicitly. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 5 +++++ > 1 file changed, 5 insertions(+) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BpnMrkMkmKTdFrwKJt6QitPtuN122iJ9n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSi87GAAoJEKeha0olJ0NqVCIH+wQa7d7WzCxue+MKwF4lyBkR lAn8GKq6wdn68ZGB68EQ2/Kzd1gWSUeGakIP3ANWN4vQKBAwTYzPs/VGVFbJKnJL ou8OPY0F3wL1zZ1+XSM0mFyvWM2YtJ8lofpNSDQXUH6EGjYeA4/ioER0A84KDABX IDb+TqW/nl7TTcQ+V8LvjieBqgegWLk3dY+lxk9I6niek4le3xLTF/pthYItyqy5 LnDnD4+NuNvk0vVEbQOcc2PeqRaodhKdxWRnw/Ywi/knSdTRG+OIOrQZzU4w+eMg jTFgoOPd07Mq5D8ZmXYad7VrAif0pwzUwaU4NIX5DP3dWykx8j5dagnz7GS8a6c= =aXGD -----END PGP SIGNATURE----- --BpnMrkMkmKTdFrwKJt6QitPtuN122iJ9n--