From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43467)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vj5Af-0003B0-Bb
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 05:38:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vj5AW-0006C2-6o
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 05:38:09 -0500
Received: from mail-ee0-x22c.google.com ([2a00:1450:4013:c00::22c]:48540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vj5AV-0006Bq-VQ
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 05:38:00 -0500
Received: by mail-ee0-f44.google.com with SMTP id d51so3909529eek.3
	for <qemu-devel@nongnu.org>; Wed, 20 Nov 2013 02:37:59 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <528C9103.9050608@redhat.com>
Date: Wed, 20 Nov 2013 11:37:55 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <F5FDBD9C42529D44A051B02D2563D5205628452C@szxema505-mbx.china.huawei.com>
	<528B1F0B.40001@redhat.com> <528BA5F7.4040105@weilnetz.de>
	<528BA8ED.7000507@redhat.com>
	<F5FDBD9C42529D44A051B02D2563D520562849C0@szxema505-mbx.china.huawei.com>
In-Reply-To: <F5FDBD9C42529D44A051B02D2563D520562849C0@szxema505-mbx.china.huawei.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in
 qemu_put_buffer() is wrong
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Wangting (Kathy)" <kathy.wangting@huawei.com>
Cc: "zhangmin (S)" <zhangmin6@huawei.com>, Juan Quintela <quintela@redhat.com>, Luonengjun <luonengjun@huawei.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Stefan Weil <stefan.weil@weilnetz.de>, "Chentao (Boby)" <boby.chen@huawei.com>, "Wangrui (K)" <moon.wangrui@huawei.com>, Anthony Liguori <anthony@codemonkey.ws>, Qinling <mail.qinling@huawei.com>, "Wubin (H)" <wu.wubin@huawei.com>

Il 20/11/2013 06:28, Wangting (Kathy) ha scritto:
> Hi Paolo and Stefan,
> 
> I am really sorry for my email before that I didn't say clearly about
> the bug fix.
> 
> f->bytes_xfer means the number of bytes which is send from source to
> destination during the migration. It is limited by the f->xfer_limit
> which is converted from bandwidth. That means if bytes_xfer is larger
> than the limit, the current iteration will not do  block and memory
> migration util the next iteration.
> 
> But in function qemu_put_buffer, the statistics is wrong. The size of
> block migration is 1MB for each block, but the buffer size for
> sending is IO_BUF_SIZE(32768bytes). When it need to be send, 1MB
> block will be divided into small trunks, so f->bytes_xfer should be
> increased by the size of the small trunks every time which is
> actually send, in function qemu_put_buffer it should be the variable
> "l".
> 
> Otherwise, f->bytes_xfer will be increased by (small trunks number *
> 1MB) while sending 1MB block, it is much larger than the size which
> is actually send, and it will soon be reached to the size of
> f->xfer_limit, so the current iteration will send less data blocks
> than expected.
> 
> If you have any questions, please let me know, thank you very much.

Thank you very much.  Juan, I guess you need to prepare another pull
request.

Paolo