From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vj7FG-0007WF-U8
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 07:51:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vj7FA-0003Gm-Vi
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 07:51:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30659)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vj7FA-0003Gc-O0
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 07:50:56 -0500
Message-ID: <528CB01B.1070302@redhat.com>
Date: Wed, 20 Nov 2013 13:50:35 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1384880863-10434-1-git-send-email-pbonzini@redhat.com>
	<1384880863-10434-8-git-send-email-pbonzini@redhat.com>
	<20131120123948.GD25447@stefanha-thinkpad.muc.redhat.com>
In-Reply-To: <20131120123948.GD25447@stefanha-thinkpad.muc.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com

Il 20/11/2013 13:39, Stefan Hajnoczi ha scritto:
>> > +
>> > +    bdi->cluster_size =
>> > +        (s->logical_sector_size / BDRV_SECTOR_SIZE) * s->block_size;
> I thought s->block_size is in bytes.  Why multiply by the logical block
> size in 512-byte sectors?

My mistake.

Paolo