From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vj8dm-0004jc-VJ
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 09:20:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vj8dh-0006C7-0U
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 09:20:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:32844)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Vj8dg-0006C2-ON
	for qemu-devel@nongnu.org; Wed, 20 Nov 2013 09:20:20 -0500
Message-ID: <528CC50D.3010706@redhat.com>
Date: Wed, 20 Nov 2013 15:19:57 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1384880863-10434-1-git-send-email-pbonzini@redhat.com>
	<1384880863-10434-21-git-send-email-pbonzini@redhat.com>
	<20131120141823.GE25447@stefanha-thinkpad.muc.redhat.com>
In-Reply-To: <20131120141823.GE25447@stefanha-thinkpad.muc.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement
 WRITE SAME
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com

Il 20/11/2013 15:18, Stefan Hajnoczi ha scritto:
>> > +    if (buffer_is_zero(inbuf, s->qdev.blocksize)) {
> Where is inbuf's size checked?  It must be s->qdev.blocksize for this
> code to be correct.
> 

See scsi_req_length:

    case WRITE_SAME_10:
    case WRITE_SAME_16:
        cmd->xfer = dev->blocksize;
        break;

Paolo