From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46331)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VjSaG-0007h7-Li
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 06:38:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VjSa8-0004DW-HC
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 06:38:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:64679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VjSa8-0004DJ-9T
	for qemu-devel@nongnu.org; Thu, 21 Nov 2013 06:38:00 -0500
Message-ID: <528DF08E.6070307@redhat.com>
Date: Thu, 21 Nov 2013 12:37:50 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1384880863-10434-1-git-send-email-pbonzini@redhat.com>
	<1384880863-10434-7-git-send-email-pbonzini@redhat.com>
	<528DEEEE.8050105@kamp.de>
In-Reply-To: <528DEEEE.8050105@kamp.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 06/20] block: make
 bdrv_co_do_write_zeroes stricter in producing aligned requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Il 21/11/2013 12:30, Peter Lieven ha scritto:
>> +            if (num <= max_write_zeroes) {
> This frees the bounce buffer ever and ever. num can never be greater than
> max_write_zeroes. So you need a num < max_write_zeroes here.

Thanks, well spotted.

Paolo